-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kibana paths configuration #63
Comments
Correct
I think we don't list all the settings in the kibana.yml file but we could add this one if you think it is important
you can just move the data folder @ygel do you think that answer your questions? |
Hello @mistic, I found some issues during testing that make MSI life harder than it needs to be:
|
@tylersmalley can you provide some help here? I think we might be able to work with @ygel in some of those items but I'm not sure about @ygel are those blockers to you? |
On Windows MSI installs "mutable" (user-serviceable) files to a separate location outside of main install path. Hence need ability to customize all paths that app and user can write to.
|
@ygel, those settings can also be specified as command line arguments. For example: |
@ygel while talking with @tylersmalley he also mentioned that for the So I think the only thing still open is the plugin dir for the kibana-plugin cli. @ygel what is your target release version for the MSI Installer? |
From the looks of it, elastic/kibana#57856 bases the key-store off of the config file. Want to make sure that when I move the config file with This however doesn't solve the problem of Maybe have |
Original target was 7.8.0. @mistic @tylersmalley At this point I believe it is too dangerous to rush Kibana MSI into 7.8.0. I am aware of these UX issues (below) that in my opinion warrant a delay to the next release. Since we don't generally add new artifacts in minor releases, it will be 7.9 for Kibana MSI.
cc: @mgreau |
@ygel agreed. I would hold off on the msi. These both have a large surface area at the fs level and if we can keep them separate for a stability period we'll have a better idea of new issues vs existing issues. Some of the issues we're seeing above^ (not kibana/static-fs related) are lower hanging fruit on the kibana side so it'll give us time to fix them at the source vs workarounds. |
@ygel, I also agree we shouldn't push this for 7.8.0. I would also like to let the static-fs sit for at least a minor version to ensure it's stable. |
I've opened an issue within respect for the problem with @tylersmalley after talking with @ygel I think I got it why he needs For the issue you were facing with Regarding the last issue with |
Running Kibana itself looks ok with Tyler's suggestion |
We did originally intend to deprecate the We will probably want to retain that warning message though, regarding relative paths. Until we have either a bundling solution for server-side plugin code or an babel plugin that allows importing from the root of the repo (elastic/kibana#52995), this warning is still relevant. |
@joshdover that means, even though we can keep using the flag and considering the fact we would want to solve this for the future instead of deprecating it, if we use it now we could have plugins that won't work. Is that correct? |
Right so the problem is that the plugin will need to be developed in the same relative location to where it is on the filesystem when deployed because of relative imports. In that way, plugins can't really be easily moved around on the filesystem without changing their source code. Maybe this should be a dev-only warning message? |
For reference, taking a page from Beats book, we could define |
@joshdover I think the warning is still useful. Maybe we could just no call it a deprecation warning 😄 I think our current point of situation here is: we will have in some close future the ability to have plugins being installed in an arbitrary directory, we cannot just doing it now for the things mentioned above. As we cannot do it now I think having an MSI installer with the ability to install custom plugins will not be possible because |
Absolutely, this was going to be my suggestion. Plugins are generally "not officially supported" so we can iterate on this and add support there later. Given the limitations of Windows, I don't think we can support them outside the main install location until we solve one of the two problems I listed above. It makes sense to decouple that from adding the MSI installer. |
Hello @mistic some questions about directories modified/added to at runtime by kibana. Please confirm, that based on [1]
config
andplugings
are considered user-serviceable, meaning user can modify/add/remove content, correct?data
directory is written to by Kibana at runtime as wellpath.data
as a setting that can be modified to move data directory somewhere, yet this setting is not in the reference kibana.yml file.optimize
also modified by Kibana at run-time?optimize
directory somewhere else?[1] https://www.elastic.co/guide/en/kibana/current/windows.html
[2] https://www.elastic.co/guide/en/kibana/current/settings.html
The text was updated successfully, but these errors were encountered: