Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCodeEditor] Wrongly implies it is edit-able #2210

Closed
walterra opened this issue Aug 8, 2019 · 4 comments
Closed

[EuiCodeEditor] Wrongly implies it is edit-able #2210

walterra opened this issue Aug 8, 2019 · 4 comments
Labels

Comments

@walterra
Copy link
Contributor

walterra commented Aug 8, 2019

This can be reproduced on the EUI example page in the read-only example: https://elastic.github.io/eui/#/forms/code-editor

Steps to reproduce:

  1. Put cursor in editor textarea
  2. Hit ESC
  3. An overlay shows up and says: Press Enter to start interacting with the code. When you're done, press Escape to stop interacting with the code.. Note on Kibana master we get: Press Enter to start editing. When you're done, press Escape to stop editing.

Suggested solution: The ESC key should not trigger the overlay in read-only mode.

image

Related Kibana/ML issue: elastic/kibana#41832

@anishagg17
Copy link
Contributor

@walterra I can't reproduce this issue

@myasonik
Copy link
Contributor

myasonik commented Mar 18, 2020

Reproduced on the EUI docs in FF. Also found a related issue in that the same overlay comes up when tabbing into the code editor.

@anishagg17 You'll also note that we've got a design decision label added to this PR which means we don't have a plan on how to solve the current issue. Do you have a suggestion? We should probably have a plan before jumping into code.

If you want to work on EuiCodeEditor, there are still the two issues you picked up earlier briefly that still require work: #2960, #2961


readonly

@anishagg17
Copy link
Contributor

anishagg17 commented Mar 18, 2020

@myasonik

If you want to work on EuiCodeEditor, there are still the two issues you picked up earlier briefly that still require work: #2960, #2961

these two issues are by the side of react-ace

one has been fixed in their update and other still needs to be fixed by them

@cchaos cchaos added ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible and removed ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Mar 18, 2020
@cchaos cchaos changed the title EuiCodeEditor wrongly implies it is edit-able [EuiCodeEditor] Wrongly implies it is edit-able Sep 20, 2020
@thompsongl
Copy link
Contributor

Closing. EuiCodeEditor has been deprecated and will soon be removed from EUI. See #3807 for recommended options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants