-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiCodeEditor] Wrongly implies it is edit-able #2210
Comments
@walterra I can't reproduce this issue |
Reproduced on the EUI docs in FF. Also found a related issue in that the same overlay comes up when tabbing into the code editor. @anishagg17 You'll also note that we've got a If you want to work on |
Closing. EuiCodeEditor has been deprecated and will soon be removed from EUI. See #3807 for recommended options. |
This can be reproduced on the EUI example page in the
read-only
example: https://elastic.github.io/eui/#/forms/code-editorSteps to reproduce:
ESC
Press Enter to start interacting with the code. When you're done, press Escape to stop interacting with the code.
. Note on Kibanamaster
we get:Press Enter to start editing. When you're done, press Escape to stop editing.
Suggested solution: The
ESC
key should not trigger the overlay inread-only
mode.Related Kibana/ML issue: elastic/kibana#41832
The text was updated successfully, but these errors were encountered: