Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand/collapse JSON in discover #59949

Closed
timroes opened this issue Mar 11, 2020 · 6 comments · Fixed by #92442
Closed

Expand/collapse JSON in discover #59949

timroes opened this issue Mar 11, 2020 · 6 comments · Fixed by #92442
Assignees
Labels
Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Mar 11, 2020

During the switch to React we switched over to use the EuiCodeBlock component, which in contrast to the previous Angular version, does not allow expanding and collapsing of parts of the JSON, as long as you view the JSON.

It seems (see linked issue below) that this request comes up. I think we should consider, maybe using a different implementation here maybe.

@timroes timroes added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@felix-lessoer
Copy link

Its not only in the JSON view but maybe also a good idea in the field view in general. As ECS has a lot of multi level fields it would also improve the UX for looking to those fields.

@kertal
Copy link
Member

kertal commented Jun 23, 2020

Linking #69614, also line numbers are missed

@kertal
Copy link
Member

kertal commented Jun 23, 2020

I can see 3 ways how we could proceed in this case:

  1. Improve EuiCodeBlock with line numbers and expanding/collapsing
  2. Step back to EuiCodeEditor (Using Ace under the hood) https://elastic.github.io/eui/#/forms/code-editor
  3. Use Monaco which is now available in Kibana to create something new

@timroes
Copy link
Contributor Author

timroes commented Oct 28, 2020

Just wanted to leave this note for prosperity: The current EUI recommendation are saying we should use monaco for it, which is available in Kibana.

@timroes
Copy link
Contributor Author

timroes commented Mar 16, 2021

Closed via #90781

@timroes timroes closed this as completed Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants