chore(map): Map cleanup #7356
Open
chore(map): Map cleanup #7356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
translations 🗣
zone config
github-actions
bot
added
the
exchange config
VIKTORVAV99
requested review from
a team and
silkeholmebonnen
and removed request for
a team
VIKTORVAV99
requested review from
tonypls and
madsnedergaard
and removed request for
silkeholmebonnen
VIKTORVAV99
commented
Oct 31, 2024
There was a problem hiding this comment.
The translations for this zone already exists.
|
Looks good! Do we want any additional messaging for the channel islands? 
|
cadeban
approved these changes
Nov 6, 2024
Not just yet, the server error is due to the fact that the backend don't have access to the config files yet. Once it does it should simply say we don't have any data for it. I'll see if I can make this more graceful in the backend at some point. |
|
@tonypls or @madsnedergaard do you have any objections? Otherwise I'll merge this later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes: AVO-611
Description
Updates the bidding zone borders between the SE subzones to be more accurate, adds the channel islands and removes the NKR zone.
Double check
pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.