From cf5e83aeee59b884b1a6be586f6929b16c802ad7 Mon Sep 17 00:00:00 2001 From: David Sanders Date: Sat, 26 Aug 2023 14:57:37 -0700 Subject: [PATCH 1/2] chore: add semver/major checklist item to deprecation review --- assets/deprecation-checklist.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/assets/deprecation-checklist.md b/assets/deprecation-checklist.md index f43b39e..85ebdc5 100644 --- a/assets/deprecation-checklist.md +++ b/assets/deprecation-checklist.md @@ -2,6 +2,7 @@ ### 🔥 New deprecations in this PR +- [ ] 🏷️ Pull request is labeled as https://github.com/electron/electron/labels/semver%2Fmajor - [ ] 📢 Are called out in [`docs/breaking-changes.md`][] - [ ] ⚠️ Use the deprecation helpers in [`lib/common/deprecate.ts`](https://github.com/electron/electron/blob/main/lib/common/deprecate.ts) to warn about usage (including events) - [ ] 📝 Are marked as deprecated in the docs, using `_Deprecated_` (including properties and events) @@ -9,6 +10,7 @@ ### 🗑️ Previous deprecations being removed in this PR +- [ ] 🏷️ Pull request is labeled as https://github.com/electron/electron/labels/semver%2Fmajor - [ ] 📢 Are called out as removed in [`docs/breaking-changes.md`][] - [ ] 📝 Are fully removed from the docs - [ ] ⌨️ All relevant code is removed From c1f311bad8aaed3c3e05349e847254ce504c5db4 Mon Sep 17 00:00:00 2001 From: David Sanders Date: Sat, 26 Aug 2023 15:03:53 -0700 Subject: [PATCH 2/2] chore: only needed on removals --- assets/deprecation-checklist.md | 1 - 1 file changed, 1 deletion(-) diff --git a/assets/deprecation-checklist.md b/assets/deprecation-checklist.md index 85ebdc5..33f980d 100644 --- a/assets/deprecation-checklist.md +++ b/assets/deprecation-checklist.md @@ -2,7 +2,6 @@ ### 🔥 New deprecations in this PR -- [ ] 🏷️ Pull request is labeled as https://github.com/electron/electron/labels/semver%2Fmajor - [ ] 📢 Are called out in [`docs/breaking-changes.md`][] - [ ] ⚠️ Use the deprecation helpers in [`lib/common/deprecate.ts`](https://github.com/electron/electron/blob/main/lib/common/deprecate.ts) to warn about usage (including events) - [ ] 📝 Are marked as deprecated in the docs, using `_Deprecated_` (including properties and events)