-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"code object is not signed at all In subcomponent" error after High Sierra update. #155
Comments
Hi @yoannmoinet I'm updating my laptop to High Sierra tonight so'll be able to try testing out the issue. Would you provide a little more details about which Electron version you are using? And it's a little weird that even a binary executable cannot be successfully signed. Did you manage to manually have this file individually signed?
Also, I'm wondering if it's an older incompatible version of |
Hi @sethlu thank you for your fast answer. I've tested both with electron Tried to sign single executable as well, exact same result. Right after the High Sierra update, I've launched XCode and it asked to install command line tools, which I did. So I guess I have the latest version there as well. I also had to reconnect my Apple Account in XCode, if it has any relevance at all. |
@yoannmoinet Mhm. I was just looking at electron-userland/electron-builder#2125 and that seems slightly related. Have you tried to package an app without non-ASCII characters and codesign that plain version? Related? https://eclecticlight.co/2017/07/05/high-sierra-and-filenames-apple-is-relenting/ |
I'll try that later today as well, right after the Sierra test. That would be weird that the non-ASCII characters is now an issue, since my app is signed and on the AppStore for several months now. I'll test it nonetheless. |
@yoannmoinet Great! I'll try to run a basic |
Removed the I think your link about the new file system is what's happening... god dammit Apple, what did you do? I'll check a bit further this direction then. |
Got it to work. It was indeed Apparently, It is now working. |
@yoannmoinet I was able to reproduce the error with a |
@yoannmoinet I've posted the reproduction here: reproduce-155. I think the issue boils down to the unicode string passed into I think we can introduce a patch to address the unicode encoding issue? Some insights from an Apple discussion: https://discussions.apple.com/thread/4714392 Amend: Also some insights here: https://eclecticlight.co/2017/04/06/apfs-is-currently-unusable-with-most-non-english-languages/ |
@sethlu awesome stuff. Copying from the Finder is indeed what I did to fix my issue. Thank you very much for your support though, without your link to the eclecticlight post, I wouldn't have found the solution. Should we re-open the issue? |
@yoannmoinet No worries! 👍 And I'm not very sure... But I'll find some time to try to devise a workaround for unicode normalization. Let's keep the issue open for some time until a fix is available. |
You're a lifesafer! Copying the characters from finder solved the same issue for me. |
Hi there,
I have updated my system to High Sierra a few days ago, and now I can't sign my apps anymore.
I've tested everything I could think off:
Always get the same error on the three Electron helpers.
MyApp.app/Contents/Frameworks/MyApp Helper EH.app/Contents/MacOS/MyApp Helper EH
MyApp.app/Contents/Frameworks/MyApp Helper NP.app/Contents/MacOS/MyApp Helper NP
MyApp.app/Contents/Frameworks/MyApp Helper.app/Contents/MacOS/MyApp Helper
I don't know what to do anymore.
Here's the full error:
I've used a simple
codesign
script to pinpoint the problem :But the output is as follow:
Please note that my app has a
ê
in its name, if that could be relevent.But I never had any issue with this before High Sierra update.
Thank you for your help.
The text was updated successfully, but these errors were encountered: