We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The change from electron/electron@5078cae has landed in Electron 28beta.
This change breaks the security check in
remote/src/renderer/remote.ts
Lines 314 to 317 in c258862
REMOTE_RENDERER_CALLBACK sent by unexpected WebContents (undefined)
Would it be enough to revert 740ed4e ? or at least accept undefined as alternative to support Electron 28+? Maybe this is not so bad anymore, since according to https://github.com/electron/electron/blob/6697042c0ab61ac55e91251427a131792de0358e/docs/breaking-changes.md?plain=1#L17C29-L17C29 the ipcRenderer shouldn't be easily leaked in future anymore...
undefined
The text was updated successfully, but these errors were encountered:
Fixed with #171
Sorry, something went wrong.
I still have this issue with Electron 28 or 29 and electron-remote 2.1.2 it's OK with Electron 27.x
I created a new issue because after this was completed there seems to be reappearance of the issue — #182.
No branches or pull requests
The change from electron/electron@5078cae has landed in Electron 28beta.
This change breaks the security check in
remote/src/renderer/remote.ts
Lines 314 to 317 in c258862
REMOTE_RENDERER_CALLBACK sent by unexpected WebContents (undefined)
and no callback execution.Would it be enough to revert 740ed4e ? or at least accept
undefined
as alternative to support Electron 28+? Maybe this is not so bad anymore, since according to https://github.com/electron/electron/blob/6697042c0ab61ac55e91251427a131792de0358e/docs/breaking-changes.md?plain=1#L17C29-L17C29 the ipcRenderer shouldn't be easily leaked in future anymore...The text was updated successfully, but these errors were encountered: