Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove of IpcRendererEvent.senderId breaks REMOTE_RENDERER_CALLBACK with Electron 28 #170

Closed
pbi-qfs opened this issue Nov 10, 2023 · 3 comments

Comments

@pbi-qfs
Copy link
Contributor

pbi-qfs commented Nov 10, 2023

The change from electron/electron@5078cae has landed in Electron 28beta.

This change breaks the security check in

if (event.senderId !== 0) {
console.error(`Message ${channel} sent by unexpected WebContents (${event.senderId})`);
return;
}
leading to the console error REMOTE_RENDERER_CALLBACK sent by unexpected WebContents (undefined) and no callback execution.

Would it be enough to revert 740ed4e ? or at least accept undefined as alternative to support Electron 28+? Maybe this is not so bad anymore, since according to https://github.com/electron/electron/blob/6697042c0ab61ac55e91251427a131792de0358e/docs/breaking-changes.md?plain=1#L17C29-L17C29 the ipcRenderer shouldn't be easily leaked in future anymore...

@pbi-qfs
Copy link
Contributor Author

pbi-qfs commented Nov 15, 2023

Fixed with #171

@pbi-qfs pbi-qfs closed this as completed Jan 15, 2024
@stephanebouget
Copy link

I still have this issue with Electron 28 or 29 and electron-remote 2.1.2
it's OK with Electron 27.x

@astoilkov
Copy link

I created a new issue because after this was completed there seems to be reappearance of the issue — #182.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants