Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg module does not rebuild according to arch #106

Open
busterbogheart opened this issue Jul 3, 2024 · 2 comments
Open

ffmpeg module does not rebuild according to arch #106

busterbogheart opened this issue Jul 3, 2024 · 2 comments

Comments

@busterbogheart
Copy link

We are using ffmpeg-static in our Electron app, but when the universal build is created, only the arm64 ffmpeg binary exists. I have confirmed that the ffmpeg-static module can be rebuilt with an arch param (npm rebuild --arch=arm64 -f ffmpeg-static, then confirmed with file node_modules/ffmpeg-static/ffmpeg) and the correct binary is created/downloaded. But when running the universal build, only os.arch() seems to be respected (which is an M1 machine in CircleCI).

If there were hooks in the universal build process, or some env vars set, I could manually rebuild this one module according to an arch. For example this ffmpeg module does read process.env.npm_config_arch, so if I were able to set that in between the x64 and arm64 builds (or electron/universal did), the module would build the correct ffmpeg binary.

@busterbogheart
Copy link
Author

It seems like there is just one step missing in the middle here, but I can't seem to find it. Does anyone have a clue?

@busterbogheart
Copy link
Author

I have confirmed that when specifying process.env.npm_config_arch as arm64 even on an Intel machine, the app builds with the correct binary of ffmpeg.

Like
process.env.npm_config_arch=arm64 npm run make -- --arch=arm64

This seems like a simple enough feature request; to set npm_config_arch at the appropriate time in the electron/universal build process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant