Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem adding multiple signatures when signing msi package #34

Closed
ToshB opened this issue Aug 14, 2024 · 1 comment
Closed

Problem adding multiple signatures when signing msi package #34

ToshB opened this issue Aug 14, 2024 · 1 comment

Comments

@ToshB
Copy link

ToshB commented Aug 14, 2024

I've set up electron-forge with the @electron-forge/maker-wix maker, and I'm attempting to sign it. It fails consistently with the following error

[FAILED: Signtool exited with code 1. Stderr: SignTool Error: Multiple signature support is not implemented for this filetype.

I've run the build with debug logging enabled, and it seems to sign successfully with sha1 first, but then fails when it attempts to sign again with sha256 (see attached log). As far as I can tell from the source it always tries to sign with both sha1 and sha256, even when the filetype apparently doesn't support multiple signatures.

Perhaps the signing algorithms could be made user configurable, so I can specify only sha256 if I don't want to double sign my package.

2024-08-13T12:51:13.063Z electron-windows-sign Spawning C:\buildagent\work\da35a521bdcf3828\node_modules\@electron\windows-sign\vendor\signtool.exe with sign,/t,http://timestamp.digicert.com,/f,C:\buildagent\work\da35a521bdcf3828\build\MyCert.pfx,/p,*******,/fd,sha1,C:\buildagent\work\da35a521bdcf3828\out\stage\make\wix\x64\MyApp.msi
2024-08-13T12:51:13.120Z electron-windows-sign Spawn C:\buildagent\work\da35a521bdcf3828\node_modules\@electron\windows-sign\vendor\signtool.exe stdout: Done Adding Additional Store
2024-08-13T12:51:14.100Z electron-windows-sign Spawn C:\buildagent\work\da35a521bdcf3828\node_modules\@electron\windows-sign\vendor\signtool.exe stdout: Successfully signed: C:\buildagent\work\da35a521bdcf3828\out\stage\make\wix\x64\MyApp.msi
2024-08-13T12:51:14.104Z electron-windows-sign Spawn C:\buildagent\work\da35a521bdcf3828\node_modules\@electron\windows-sign\vendor\signtool.exe: Child process exited with code 0
2024-08-13T12:51:14.109Z electron-windows-sign Spawning C:\buildagent\work\da35a521bdcf3828\node_modules\@electron\windows-sign\vendor\signtool.exe with sign,/as,/tr,http://timestamp.digicert.com,/td,sha256,/f,C:\buildagent\work\da35a521bdcf3828\build\MyCert.pfx,/p,*******,/fd,sha256,C:\buildagent\work\da35a521bdcf3828\out\stage\make\wix\x64\MyApp.msi
2024-08-13T12:51:14.166Z electron-windows-sign Spawn C:\buildagent\work\da35a521bdcf3828\node_modules\@electron\windows-sign\vendor\signtool.exe stdout: Done Adding Additional Store
2024-08-13T12:51:14.376Z electron-windows-sign Spawn C:\buildagent\work\da35a521bdcf3828\node_modules\@electron\windows-sign\vendor\signtool.exe stdout:
2024-08-13T12:51:14.378Z electron-windows-sign Spawn C:\buildagent\work\da35a521bdcf3828\node_modules\@electron\windows-sign\vendor\signtool.exe stdout: Number of errors: 1
2024-08-13T12:51:14.379Z electron-windows-sign Spawn C:\buildagent\work\da35a521bdcf3828\node_modules\@electron\windows-sign\vendor\signtool.exe stderr: SignTool Error: Multiple signature support is not implemented for this filetype.
SignTool Error: An error occurred while attempting to sign: C:\buildagent\work\da35a521bdcf3828\out\stage\make\wix\x64\MyApp.msi
2024-08-13T12:51:14.383Z electron-windows-sign Spawn C:\buildagent\work\da35a521bdcf3828\node_modules\@electron\windows-sign\vendor\signtool.exe: Child process exited with code 1
× Making a wix distributable for win32/x64 [FAILED: Signtool exited with code 1. Stderr: SignTool Error: Multiple signature support is not implemented for this filetype.
SignTool Error: An error occurred while attempting to sign: C:\buildagent\work\da35a521bdcf3828\out\stage\make\wix\x64\MyApp.msi
@ToshB
Copy link
Author

ToshB commented Aug 15, 2024

Duplicate of #19

@ToshB ToshB closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant