Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config flag for ED to customize the location of config.json #1897

Open
pmaier1 opened this issue Oct 1, 2024 · 3 comments
Open

Add a config flag for ED to customize the location of config.json #1897

pmaier1 opened this issue Oct 1, 2024 · 3 comments
Labels
A-App Settings Application settings A-Config O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement T-Feature Request to add a new feature which does not exist right now X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@pmaier1
Copy link

pmaier1 commented Oct 1, 2024

Your use case

What would you like to do?

Add a config flag for ED to customize the location of config.json such that it can point to the one exposed by ESS. This way the admin can live edit it using e.g., admin console or other hooks. Customer admins can set the flag via their ED installer (e.g., MSI).

Why would you like to do it?

  • There are certain configurations that administrators will set in ESS (example)
  • For EW we can just change config.json on-the-fly ✔️
  • Currently there is no (simple) way to automatically propagate them to ED since ED relies on a hardcoded local config.json (if I'm not mistaken)

How would you like to achieve it?

The idea is that there would be something like a build flag (e.g., in MSI for Windows) such that administrators can roll out ED with a pre-configured location for config.json. This way we imagine that changes in ESS will automatically propagate to ED instances.

@daniellekirkwood @langleyd

Have you considered any alternatives?

No response

Additional context

No response

@dosubot dosubot bot added A-App Settings Application settings T-Feature Request to add a new feature which does not exist right now labels Oct 1, 2024
@t3chguy
Copy link
Member

t3chguy commented Oct 1, 2024

By location do you mean system file path or do you mean web URL? If the latter we'd need designs for the state for when the config cannot be loaded. I guess we'd need that if the config file was missing on the filesystem too.

Related #731
Related element-hq/element-web#13678

@t3chguy t3chguy added the X-Needs-Info This issue is blocked awaiting information from the reporter label Oct 1, 2024
@t3chguy t3chguy transferred this issue from element-hq/element-web Oct 1, 2024
@dosubot dosubot bot added A-Config O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 1, 2024
@Half-Shot
Copy link
Member

@pmaier1 @t3chguy does #1921 solve this?

@davidegirardi
Copy link

In my opinion yes and we also avoid building different packages for different configuration paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-App Settings Application settings A-Config O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement T-Feature Request to add a new feature which does not exist right now X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

No branches or pull requests

4 participants