Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to composer decoration and room badges #29425

Open
americanrefugee opened this issue Mar 4, 2025 · 1 comment
Open

Updates to composer decoration and room badges #29425

americanrefugee opened this issue Mar 4, 2025 · 1 comment
Labels
A-Composer A-E2EE O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement

Comments

@americanrefugee
Copy link

Your use case

Related to https://github.com/matrix-org/internal-config/issues/1606#issuecomment-2694734081

We've decided to make a couple changes to decoration that need to be implemented on EW:

  1. Composer decoration

Encrypted = No icon + "Send message..." / "Message..."

Unencrypted = Blue broken lock icon + "Send unencrypted message..." / "Unencrypted message..."

  1. Room badges (room info)

Unencrypted = blue badge

Public = blue badge

Example:

Full room views for all platforms

Compound components:

Have you considered any alternatives?

Yes, we originally defined:

  • Encrypted rooms would have a green lock in the composer
  • Unencrypted rooms would have no decoration in the composer and gray badges in room info

But after aligning with @mxandreas @dkasak and @kongo09 we've decided to only show decoration in the composer when the room is unencrypted in order to fulfill our vision of "invisible crypto".

To this end we've decided to make the broken lock icon and corresponding badges for "Not encrypted" and "Public room" blue instead of gray.

This will be for all platforms.

Additional context

No response

@mxandreas
Copy link

I guess this should be simply a "task" for the Web team with the spec coming from element-hq/element-meta#2746 but for the moment I did not re-write it, just linked as a sub-issue to have correct tracking.

pixlwave added a commit to element-hq/compound-design-tokens that referenced this issue Mar 6, 2025
* Add tokens for badge background and text.
element-hq/element-web#29425
element-hq/element-x-ios#3867
element-hq/element-x-android#4356

* Add $themes.json
(Exported styles to Figma first, then Token Studio recognised changes)

* Generate assets.

---------

Co-authored-by: Doug <[email protected]>
@dbkr dbkr added the O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-E2EE O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants