Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move public room call invite mitigations to filter_events_for_client #17359

Open
anoadragon453 opened this issue Jun 25, 2024 · 0 comments · May be fixed by #17782
Open

Move public room call invite mitigations to filter_events_for_client #17359

anoadragon453 opened this issue Jun 25, 2024 · 0 comments · May be fixed by #17782
Assignees
Labels
A-Sync good first issue This is a fix that might be an easy place for someone to start for their first contribution T-Task Z-Dev-Wishlist

Comments

@anoadragon453
Copy link
Member

anoadragon453 commented Jun 25, 2024

This bit of code filters out call invite events in public rooms to prevent someone from being able to ring hundreds of people by sending a call event:

loaded_recents = []
for event in filtered_recents:
if event.type == EventTypes.CallInvite:
room_info = await self.store.get_room_with_stats(event.room_id)
assert room_info is not None
if room_info.join_rules == JoinRules.PUBLIC:
continue
loaded_recents.append(event)

@MadLittleMods asks whether it can be moved to filter_events_for_client rather than its current spot in _load_filtered_recents, so that the new native sliding sync implementation can utilise it (#16908 (comment)). Another alternative is to soft_fail the call invites.

@anoadragon453 anoadragon453 added good first issue This is a fix that might be an easy place for someone to start for their first contribution A-Sync T-Task Z-Dev-Wishlist labels Jun 25, 2024
@anoadragon453 anoadragon453 self-assigned this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Sync good first issue This is a fix that might be an easy place for someone to start for their first contribution T-Task Z-Dev-Wishlist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant