Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ubuntu-keyring from apt again instead of using deprecated apt-key #723

Open
ryonakano opened this issue Oct 19, 2024 · 0 comments
Open
Labels
Priority: Low On the radar, but not the most urgent thing Status: Blocked Something else needs to be done before this can be fixed

Comments

@ryonakano
Copy link
Contributor

Problem

We're using the deprecated apt-key during the build process:

os/build.sh

Line 33 in dcfbeb5

apt-key adv --recv-keys --keyserver keyserver.ubuntu.com F6ECB3762474EDA9D21B7022871920D1991BC93C

You can see the warning if you build the image:

Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
Executing: /tmp/apt-key-gpghome.sUZHX0hGxx/gpg.1.sh --recv-keys --keyserver keyserver.ubuntu.com F6ECB3762474EDA9D21B7022871920D1991BC93C
gpg: key 871920D1991BC93C: public key "Ubuntu Archive Automatic Signing Key (2018) <[email protected]>" imported
gpg: Total number processed: 1
gpg:               imported: 1

Proposal

Replace the deprecated apt-key command.

It looks like the ubuntu-keyring package came back to the debian repository since Trixie (see https://packages.debian.org/search?searchon=names&keywords=ubuntu-keyring), so maybe we can simply install it with apt when the debian:latest docker image is based on Trixie (it's based on Bookworm at the moment).

Prior Art (Optional)

#565 for the previous code that installs ubuntu-keyring from apt

@ryonakano ryonakano added Priority: Low On the radar, but not the most urgent thing Status: Blocked Something else needs to be done before this can be fixed labels Oct 19, 2024
@danirabbit danirabbit added this to OS 9 Oct 23, 2024
@danirabbit danirabbit moved this to Todo in OS 9 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low On the radar, but not the most urgent thing Status: Blocked Something else needs to be done before this can be fixed
Projects
Status: Confirmed
Development

No branches or pull requests

1 participant