From bb11f5f02b01a842d387d740a48536aab4e9bda1 Mon Sep 17 00:00:00 2001
From: Fred Atherden <43879983+fred-atherden@users.noreply.github.com>
Date: Mon, 17 Feb 2025 09:24:51 +0000
Subject: [PATCH 1/6] RP - add check for incomplete DOIs in refs

---
 src/rp-schematron-base.sch                    |   4 +
 src/rp-schematron.sch                         |   2 +
 src/rp-schematron.xsl                         |  15 ++
 .../ref-pub-id-checks/pub-id-check-6/fail.xml |  11 ++
 .../ref-pub-id-checks/pub-id-check-6/pass.xml |  11 ++
 .../pub-id-check-6/pub-id-check-6.sch         | 157 ++++++++++++++++++
 test/xspec/rp-schematron.sch                  |   2 +
 test/xspec/rp-schematron.xspec                |  10 ++
 8 files changed, 212 insertions(+)
 create mode 100644 test/tests/rp/ref-pub-id-checks/pub-id-check-6/fail.xml
 create mode 100644 test/tests/rp/ref-pub-id-checks/pub-id-check-6/pass.xml
 create mode 100644 test/tests/rp/ref-pub-id-checks/pub-id-check-6/pub-id-check-6.sch

diff --git a/src/rp-schematron-base.sch b/src/rp-schematron-base.sch
index 45b23734b7..80b59ff84d 100644
--- a/src/rp-schematron-base.sch
+++ b/src/rp-schematron-base.sch
@@ -784,6 +784,10 @@
         <report test="ancestor::mixed-citation[@publication-type='web']" 
           role="error" 
           id="pub-id-check-5">Web reference (with id <value-of select="ancestor::ref/@id"/>) has a <name/> <value-of select="if (@pub-id-type) then concat('with a pub-id-type ',@pub-id-type) else 'with no pub-id-type'"/> (<value-of select="."/>). This must be incorrect. Either the publication-type for the reference needs changing, or the pub-id should be changed to another element.</report>
+        
+        <report test="@pub-id-type='doi' and ancestor::mixed-citation[@publication-type=('journal','book','preprint')] and matches(following-sibling::text()[1],'^[\.\s]?[\.\s]?[/&lt;&gt;:\d\+\-]')" 
+          role="warning" 
+          id="pub-id-check-6">doi in <value-of select="ancestor::mixed-citation/@publication-type"/> ref is followd by text - '<value-of select="following-sibling::text()[1]"/>'. Should that text be part of the DOI or tagged in some other way?</report>
      </rule>
 
       <rule context="ref//pub-id[@pub-id-type='isbn']|isbn" id="isbn-conformity">
diff --git a/src/rp-schematron.sch b/src/rp-schematron.sch
index f06ee164b3..eeda09357e 100644
--- a/src/rp-schematron.sch
+++ b/src/rp-schematron.sch
@@ -462,6 +462,8 @@
         <report test="ancestor::mixed-citation[@publication-type='preprint'] and not(@pub-id-type=('doi','pmid','pmcid','arxiv'))" role="error" id="pub-id-check-4">[pub-id-check-4] <name/> is within a journal reference, but it does not have one of the following permitted @pub-id-type values: 'doi','pmid','pmcid','arxiv'.</report>
 
         <report test="ancestor::mixed-citation[@publication-type='web']" role="error" id="pub-id-check-5">[pub-id-check-5] Web reference (with id <value-of select="ancestor::ref/@id"/>) has a <name/> <value-of select="if (@pub-id-type) then concat('with a pub-id-type ',@pub-id-type) else 'with no pub-id-type'"/> (<value-of select="."/>). This must be incorrect. Either the publication-type for the reference needs changing, or the pub-id should be changed to another element.</report>
+        
+        <report test="@pub-id-type='doi' and ancestor::mixed-citation[@publication-type=('journal','book','preprint')] and matches(following-sibling::text()[1],'^[\.\s]?[\.\s]?[/&lt;&gt;:\d\+\-]')" role="warning" id="pub-id-check-6">[pub-id-check-6] doi in <value-of select="ancestor::mixed-citation/@publication-type"/> ref is followd by text - '<value-of select="following-sibling::text()[1]"/>'. Should that text be part of the DOI or tagged in some other way?</report>
      </rule></pattern><pattern id="isbn-conformity-pattern"><rule context="ref//pub-id[@pub-id-type='isbn']|isbn" id="isbn-conformity">
         <let name="t" value="translate(.,'-','')"/>
         <let name="sum" value="e:isbn-sum($t)"/>
diff --git a/src/rp-schematron.xsl b/src/rp-schematron.xsl
index 1899c78930..279afdc1d5 100644
--- a/src/rp-schematron.xsl
+++ b/src/rp-schematron.xsl
@@ -3611,6 +3611,21 @@
                <xsl:text/>). This must be incorrect. Either the publication-type for the reference needs changing, or the pub-id should be changed to another element.</svrl:text>
          </svrl:successful-report>
       </xsl:if>
+      <!--REPORT warning-->
+      <xsl:if test="@pub-id-type='doi' and ancestor::mixed-citation[@publication-type=('journal','book','preprint')] and matches(following-sibling::text()[1],'^[\.\s]?[\.\s]?[/&lt;&gt;:\d\+\-]')">
+         <svrl:successful-report xmlns:svrl="http://purl.oclc.org/dsdl/svrl" test="@pub-id-type='doi' and ancestor::mixed-citation[@publication-type=('journal','book','preprint')] and matches(following-sibling::text()[1],'^[\.\s]?[\.\s]?[/&lt;&gt;:\d\+\-]')">
+            <xsl:attribute name="id">pub-id-check-6</xsl:attribute>
+            <xsl:attribute name="role">warning</xsl:attribute>
+            <xsl:attribute name="location">
+               <xsl:apply-templates select="." mode="schematron-select-full-path"/>
+            </xsl:attribute>
+            <svrl:text>[pub-id-check-6] doi in <xsl:text/>
+               <xsl:value-of select="ancestor::mixed-citation/@publication-type"/>
+               <xsl:text/> ref is followd by text - '<xsl:text/>
+               <xsl:value-of select="following-sibling::text()[1]"/>
+               <xsl:text/>'. Should that text be part of the DOI or tagged in some other way?</svrl:text>
+         </svrl:successful-report>
+      </xsl:if>
       <xsl:apply-templates select="*" mode="M50"/>
    </xsl:template>
    <xsl:template match="text()" priority="-1" mode="M50"/>
diff --git a/test/tests/rp/ref-pub-id-checks/pub-id-check-6/fail.xml b/test/tests/rp/ref-pub-id-checks/pub-id-check-6/fail.xml
new file mode 100644
index 0000000000..4576bb2030
--- /dev/null
+++ b/test/tests/rp/ref-pub-id-checks/pub-id-check-6/fail.xml
@@ -0,0 +1,11 @@
+<?oxygen SCHSchema="pub-id-check-6.sch"?>
+<!--Context: ref//pub-id
+Test: report    @pub-id-type='doi' and ancestor::mixed-citation[@publication-type=('journal','book','preprint')] and matches(following-sibling::text()[1],'^[\.\s]?[\.\s]?[/<>:\d\+\-]')
+Message: doi in  ref is followd by text - ''. Should that text be part of the DOI or tagged in some other way? -->
+<root xmlns:ali="http://www.niso.org/schemas/ali/1.0/" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:xlink="http://www.w3.org/1999/xlink">
+    <article>
+        <ref>
+            <mixed-citation publication-type="journal"><pub-id pub-id-type="doi">10.7554/eLife.100870</pub-id>. 2</mixed-citation>
+        </ref>
+    </article>
+</root>
\ No newline at end of file
diff --git a/test/tests/rp/ref-pub-id-checks/pub-id-check-6/pass.xml b/test/tests/rp/ref-pub-id-checks/pub-id-check-6/pass.xml
new file mode 100644
index 0000000000..b43baa1540
--- /dev/null
+++ b/test/tests/rp/ref-pub-id-checks/pub-id-check-6/pass.xml
@@ -0,0 +1,11 @@
+<?oxygen SCHSchema="pub-id-check-6.sch"?>
+<!--Context: ref//pub-id
+Test: report    @pub-id-type='doi' and ancestor::mixed-citation[@publication-type=('journal','book','preprint')] and matches(following-sibling::text()[1],'^[\.\s]?[\.\s]?[/<>:\d\+\-]')
+Message: doi in  ref is followd by text - ''. Should that text be part of the DOI or tagged in some other way? -->
+<root xmlns:ali="http://www.niso.org/schemas/ali/1.0/" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:xlink="http://www.w3.org/1999/xlink">
+    <article>
+        <ref>
+            <mixed-citation publication-type="journal"><pub-id pub-id-type="doi">10.7554/eLife.100870.2</pub-id></mixed-citation>
+        </ref>
+    </article>
+</root>
\ No newline at end of file
diff --git a/test/tests/rp/ref-pub-id-checks/pub-id-check-6/pub-id-check-6.sch b/test/tests/rp/ref-pub-id-checks/pub-id-check-6/pub-id-check-6.sch
new file mode 100644
index 0000000000..3afbd5aab3
--- /dev/null
+++ b/test/tests/rp/ref-pub-id-checks/pub-id-check-6/pub-id-check-6.sch
@@ -0,0 +1,157 @@
+<schema xmlns="http://purl.oclc.org/dsdl/schematron" xmlns:meca="http://manuscriptexchange.org" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:ali="http://www.niso.org/schemas/ali/1.0/" xmlns:file="java.io.File" xmlns:java="http://www.java.com/" xmlns:xsl="http://www.w3.org/1999/XSL/Transform" xmlns:xlink="http://www.w3.org/1999/xlink" queryBinding="xslt2">
+  <title>eLife reviewed preprint schematron</title>
+  <ns uri="http://www.niso.org/schemas/ali/1.0/" prefix="ali"/>
+  <ns uri="http://www.w3.org/XML/1998/namespace" prefix="xml"/>
+  <ns uri="http://www.w3.org/1999/xlink" prefix="xlink"/>
+  <ns uri="http://www.w3.org/2001/XInclude" prefix="xi"/>
+  <ns uri="http://www.w3.org/1998/Math/MathML" prefix="mml"/>
+  <ns uri="http://saxon.sf.net/" prefix="saxon"/>
+  <ns uri="http://purl.org/dc/terms/" prefix="dc"/>
+  <ns uri="http://www.w3.org/2001/XMLSchema" prefix="xs"/>
+  <ns uri="https://elifesciences.org/namespace" prefix="e"/>
+  <ns uri="java.io.File" prefix="file"/>
+  <ns uri="http://www.java.com/" prefix="java"/>
+  <ns uri="http://manuscriptexchange.org" prefix="meca"/>
+  <xsl:function name="e:isbn-sum" as="xs:integer">
+    <xsl:param name="s" as="xs:string"/>
+    <xsl:choose>
+      <xsl:when test="string-length($s) = 10">
+        <xsl:variable name="d1" select="number(substring($s,1,1)) * 10"/>
+        <xsl:variable name="d2" select="number(substring($s,2,1)) * 9"/>
+        <xsl:variable name="d3" select="number(substring($s,3,1)) * 8"/>
+        <xsl:variable name="d4" select="number(substring($s,4,1)) * 7"/>
+        <xsl:variable name="d5" select="number(substring($s,5,1)) * 6"/>
+        <xsl:variable name="d6" select="number(substring($s,6,1)) * 5"/>
+        <xsl:variable name="d7" select="number(substring($s,7,1)) * 4"/>
+        <xsl:variable name="d8" select="number(substring($s,8,1)) * 3"/>
+        <xsl:variable name="d9" select="number(substring($s,9,1)) * 2"/>
+        <xsl:variable name="d10" select="number(substring($s,10,1)) * 1"/>
+        <xsl:value-of select="number($d1 + $d2 + $d3 + $d4 + $d5 + $d6 + $d7 + $d8 + $d9 + $d10) mod 11"/>
+      </xsl:when>
+      <xsl:when test="string-length($s) = 13">
+        <xsl:variable name="d1" select="number(substring($s,1,1))"/>
+        <xsl:variable name="d2" select="number(substring($s,2,1)) * 3"/>
+        <xsl:variable name="d3" select="number(substring($s,3,1))"/>
+        <xsl:variable name="d4" select="number(substring($s,4,1)) * 3"/>
+        <xsl:variable name="d5" select="number(substring($s,5,1))"/>
+        <xsl:variable name="d6" select="number(substring($s,6,1)) * 3"/>
+        <xsl:variable name="d7" select="number(substring($s,7,1))"/>
+        <xsl:variable name="d8" select="number(substring($s,8,1)) * 3"/>
+        <xsl:variable name="d9" select="number(substring($s,9,1))"/>
+        <xsl:variable name="d10" select="number(substring($s,10,1)) * 3"/>
+        <xsl:variable name="d11" select="number(substring($s,11,1))"/>
+        <xsl:variable name="d12" select="number(substring($s,12,1)) * 3"/>
+        <xsl:variable name="d13" select="number(substring($s,13,1))"/>
+        <xsl:value-of select="number($d1 + $d2 + $d3 + $d4 + $d5 + $d6 + $d7 + $d8 + $d9 + $d10 + $d11 + $d12 + $d13) mod 10"/>
+      </xsl:when>
+      <xsl:otherwise>
+        <xsl:value-of select="number('1')"/>
+      </xsl:otherwise>
+    </xsl:choose>
+  </xsl:function>
+  <xsl:function name="e:is-valid-issn" as="xs:boolean">
+      <xsl:param name="s" as="xs:string"/>
+      <xsl:choose>
+        <xsl:when test="not(matches($s,'^\d{4}\-\d{3}[\dX]$'))">
+          <xsl:value-of select="false()"/>
+        </xsl:when>
+        <xsl:otherwise>
+            <xsl:variable name="d1" select="number(substring($s,1,1)) * 8"/>
+            <xsl:variable name="d2" select="number(substring($s,2,1)) * 7"/>
+            <xsl:variable name="d3" select="number(substring($s,3,1)) * 6"/>
+            <xsl:variable name="d4" select="number(substring($s,4,1)) * 5"/>
+            <xsl:variable name="d5" select="number(substring($s,6,1)) * 4"/>
+            <xsl:variable name="d6" select="number(substring($s,7,1)) * 3"/>
+            <xsl:variable name="d7" select="number(substring($s,8,1)) * 2"/>
+            <xsl:variable name="remainder" select="number($d1 + $d2 + $d3 + $d4 + $d5 + $d6 + $d7) mod 11"/>
+            <xsl:variable name="calc" select="if ($remainder=0) then 0 else (11 - $remainder)"/>
+            <xsl:variable name="check" select="if (substring($s,9,1)='X') then 10 else number(substring($s,9,1))"/>
+            <xsl:value-of select="$calc = $check"/>
+        </xsl:otherwise>
+      </xsl:choose>
+    </xsl:function>
+  <xsl:function name="e:get-name" as="xs:string">
+    <xsl:param name="name"/>
+    <xsl:choose>
+      <xsl:when test="$name/given-names[1] and $name/surname[1] and $name/suffix[1]">
+        <xsl:value-of select="concat($name/given-names[1],' ',$name/surname[1],' ',$name/suffix[1])"/>
+      </xsl:when>
+      <xsl:when test="not($name/given-names[1]) and $name/surname[1] and $name/suffix[1]">
+        <xsl:value-of select="concat($name/surname[1],' ',$name/suffix[1])"/>
+      </xsl:when>
+      <xsl:when test="$name/given-names[1] and $name/surname[1] and not($name/suffix[1])">
+        <xsl:value-of select="concat($name/given-names[1],' ',$name/surname[1])"/>
+      </xsl:when>
+      <xsl:when test="not($name/given-names[1]) and $name/surname[1] and not($name/suffix[1])">
+        <xsl:value-of select="$name/surname[1]"/>
+      </xsl:when>
+      <xsl:otherwise>
+        <xsl:value-of select="'No elements present'"/>
+      </xsl:otherwise>
+    </xsl:choose>
+  </xsl:function>
+  <xsl:function name="e:get-copyright-holder">
+    <xsl:param name="contrib-group"/>
+    <xsl:variable name="author-count" select="count($contrib-group/contrib[@contrib-type='author'])"/>
+    <xsl:choose>
+      <xsl:when test="$author-count lt 1"/>
+      <xsl:when test="$author-count = 1">
+        <xsl:choose>
+          <xsl:when test="$contrib-group/contrib[@contrib-type='author']/collab">
+            <xsl:value-of select="$contrib-group/contrib[@contrib-type='author']/collab[1]/text()[1]"/>
+          </xsl:when>
+          <xsl:otherwise>
+            <xsl:value-of select="$contrib-group/contrib[@contrib-type='author']/name[1]/surname[1]"/>
+          </xsl:otherwise>
+        </xsl:choose>
+      </xsl:when>
+      <xsl:when test="$author-count = 2">
+        <xsl:choose>
+          <xsl:when test="$contrib-group/contrib[@contrib-type='author']/collab">
+            <xsl:choose>
+              <xsl:when test="$contrib-group/contrib[@contrib-type='author'][1]/collab and $contrib-group/contrib[@contrib-type='author'][2]/collab">
+                <xsl:value-of select="concat($contrib-group/contrib[@contrib-type='author']/collab[1]/text()[1],' &amp; ',$contrib-group/contrib[@contrib-type='author']/collab[2]/text()[1])"/>
+              </xsl:when>
+              <xsl:when test="$contrib-group/contrib[@contrib-type='author'][1]/collab">
+                <xsl:value-of select="concat($contrib-group/contrib[@contrib-type='author'][1]/collab[1]/text()[1],' &amp; ',$contrib-group/contrib[@contrib-type='author'][2]/name[1]/surname[1])"/>
+              </xsl:when>
+              <xsl:otherwise>
+                <xsl:value-of select="concat($contrib-group/contrib[@contrib-type='author'][1]/name[1]/surname[1],' &amp; ',$contrib-group/contrib[@contrib-type='author'][2]/collab[1]/text()[1])"/>
+              </xsl:otherwise>
+            </xsl:choose>
+          </xsl:when>
+          <xsl:otherwise>
+            <xsl:value-of select="concat($contrib-group/contrib[@contrib-type='author'][1]/name[1]/surname[1],' &amp; ',$contrib-group/contrib[@contrib-type='author'][2]/name[1]/surname[1])"/>
+          </xsl:otherwise>
+        </xsl:choose>
+      </xsl:when>
+      
+      <xsl:otherwise>
+        <xsl:variable name="is-equal-contrib" select="if ($contrib-group/contrib[@contrib-type='author'][1]/@equal-contrib='yes') then true() else false()"/>
+        
+        <xsl:value-of select="concat(e:get-surname($contrib-group/contrib[@contrib-type='author'][1]),' et al')"/>
+      </xsl:otherwise>
+    </xsl:choose>
+  </xsl:function>
+  <xsl:function name="e:get-surname" as="text()">
+    <xsl:param name="contrib"/>
+    <xsl:choose>
+      <xsl:when test="$contrib/collab">
+        <xsl:value-of select="$contrib/collab[1]/text()[1]"/>
+      </xsl:when>
+      <xsl:otherwise>
+        <xsl:value-of select="$contrib//name[1]/surname[1]"/>
+      </xsl:otherwise>
+    </xsl:choose>
+  </xsl:function>
+  <pattern id="ref-pub-id-checks-pattern">
+    <rule context="ref//pub-id" id="ref-pub-id-checks">
+      <report test="@pub-id-type='doi' and ancestor::mixed-citation[@publication-type=('journal','book','preprint')] and matches(following-sibling::text()[1],'^[\.\s]?[\.\s]?[/&lt;&gt;:\d\+\-]')" role="warning" id="pub-id-check-6">[pub-id-check-6] doi in <value-of select="ancestor::mixed-citation/@publication-type"/> ref is followd by text - '<value-of select="following-sibling::text()[1]"/>'. Should that text be part of the DOI or tagged in some other way?</report>
+    </rule>
+  </pattern>
+  <pattern id="root-pattern">
+    <rule context="root" id="root-rule">
+      <assert test="descendant::ref//pub-id" role="error" id="ref-pub-id-checks-xspec-assert">ref//pub-id must be present.</assert>
+    </rule>
+  </pattern>
+</schema>
\ No newline at end of file
diff --git a/test/xspec/rp-schematron.sch b/test/xspec/rp-schematron.sch
index d2c8b7cba2..d45b52245e 100644
--- a/test/xspec/rp-schematron.sch
+++ b/test/xspec/rp-schematron.sch
@@ -569,6 +569,8 @@
         <name/> is within a journal reference, but it does not have one of the following permitted @pub-id-type values: 'doi','pmid','pmcid','arxiv'.</report>
 
         <report test="ancestor::mixed-citation[@publication-type='web']" role="error" id="pub-id-check-5">Web reference (with id <value-of select="ancestor::ref/@id"/>) has a <name/> <value-of select="if (@pub-id-type) then concat('with a pub-id-type ',@pub-id-type) else 'with no pub-id-type'"/> (<value-of select="."/>). This must be incorrect. Either the publication-type for the reference needs changing, or the pub-id should be changed to another element.</report>
+        
+        <report test="@pub-id-type='doi' and ancestor::mixed-citation[@publication-type=('journal','book','preprint')] and matches(following-sibling::text()[1],'^[\.\s]?[\.\s]?[/&lt;&gt;:\d\+\-]')" role="warning" id="pub-id-check-6">doi in <value-of select="ancestor::mixed-citation/@publication-type"/> ref is followd by text - '<value-of select="following-sibling::text()[1]"/>'. Should that text be part of the DOI or tagged in some other way?</report>
      </rule>
   </pattern>
   <pattern id="isbn-conformity-pattern">
diff --git a/test/xspec/rp-schematron.xspec b/test/xspec/rp-schematron.xspec
index 694fbcfc9d..3d2945c83a 100644
--- a/test/xspec/rp-schematron.xspec
+++ b/test/xspec/rp-schematron.xspec
@@ -1255,6 +1255,16 @@
         <x:expect-report id="pub-id-check-5" role="error"/>
         <x:expect-not-assert id="ref-pub-id-checks-xspec-assert" role="error"/>
       </x:scenario>
+      <x:scenario label="pub-id-check-6-pass">
+        <x:context href="../tests/rp/ref-pub-id-checks/pub-id-check-6/pass.xml"/>
+        <x:expect-not-report id="pub-id-check-6" role="warning"/>
+        <x:expect-not-assert id="ref-pub-id-checks-xspec-assert" role="error"/>
+      </x:scenario>
+      <x:scenario label="pub-id-check-6-fail">
+        <x:context href="../tests/rp/ref-pub-id-checks/pub-id-check-6/fail.xml"/>
+        <x:expect-report id="pub-id-check-6" role="warning"/>
+        <x:expect-not-assert id="ref-pub-id-checks-xspec-assert" role="error"/>
+      </x:scenario>
     </x:scenario>
     <x:scenario label="isbn-conformity">
       <x:scenario label="isbn-conformity-test-pass">

From dfcf35d0bebc2c654c001158b5f47c8d71abd485 Mon Sep 17 00:00:00 2001
From: Fred Atherden <43879983+fred-atherden@users.noreply.github.com>
Date: Mon, 17 Feb 2025 09:32:56 +0000
Subject: [PATCH 2/6] RP XSL - eLife casing in refs

---
 src/preprint-changes.xsl                                   | 7 +++++++
 test/tests/preprint-changes/all/output.xml                 | 2 +-
 .../preprint-changes/fix-common-ref-issues/output.xml      | 2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/preprint-changes.xsl b/src/preprint-changes.xsl
index 8cf390def3..2bc81163cd 100644
--- a/src/preprint-changes.xsl
+++ b/src/preprint-changes.xsl
@@ -1239,6 +1239,13 @@
     <!-- Fixes mistagged and all caps source elements -->
      <xsl:template xml:id="ref-source-fixes" match="mixed-citation//source">
          <xsl:choose>
+             <!-- Fix casing for eLife -->
+             <xsl:when test="matches(lower-case(.),'^\s*elife\s*$') and not(matches(.,'^\s*eLife\s*$'))">
+                    <xsl:copy>
+                        <xsl:apply-templates select="@*"/>
+                        <xsl:text>eLife</xsl:text>
+                    </xsl:copy>
+                </xsl:when>
                 <xsl:when test="matches(lower-case(.),'^in\s')">
                     <xsl:choose>
                         <xsl:when test="(ancestor::mixed-citation/@publication-type=('preprint','journal','other')) and upper-case(.)=.">
diff --git a/test/tests/preprint-changes/all/output.xml b/test/tests/preprint-changes/all/output.xml
index 88e0fc7a91..e884c104b9 100644
--- a/test/tests/preprint-changes/all/output.xml
+++ b/test/tests/preprint-changes/all/output.xml
@@ -185,7 +185,7 @@
 <ref id="c3"><label>3.</label><mixed-citation publication-type="preprint"><year>2024</year><article-title/> <source>bioRxiv</source></mixed-citation></ref>
 <ref id="c4"><label>4.</label><mixed-citation publication-type="book"><person-group person-group-type="author"><string-name><given-names>A.</given-names> <surname>Nagy</surname></string-name>, <string-name><given-names>M.</given-names> <surname>Gertsenstein</surname></string-name>, <string-name><given-names>K.</given-names> <surname>Vintersten</surname></string-name>, <etal>…</etal> <string-name><given-names>R.</given-names> <surname>Behringer</surname></string-name></person-group>, <source>Manipulating the mouse embryo: a laboratory manual</source> (<publisher-name>Cold Spring Harbor Laboratory Press Cold Spring Harbor</publisher-name>, NY:, <year>2003</year>), vol. <volume>10</volume>.</mixed-citation></ref>
 <ref id="c5"><label>5.</label><mixed-citation publication-type="book"><person-group person-group-type="author"><string-name><given-names>J. M.</given-names> <surname>Glynn</surname></string-name>, <string-name><given-names>T. G.</given-names> <surname>Cotter</surname></string-name>, <string-name><given-names>D. R.</given-names> <surname>Green</surname></string-name></person-group> (<year>1992</year>) <source>Apoptosis induced by actinomycin D, camptothecin or aphidicolin can occur in all phases of the cell cycle</source>. (<publisher-loc>Portland</publisher-loc> <publisher-name>Press Ltd</publisher-name>.).</mixed-citation></ref>
-<ref id="c6"><label>6.</label><mixed-citation publication-type="journal"><person-group person-group-type="author"><string-name><surname>Huckesfeld</surname> <given-names>S</given-names></string-name>, <etal>et al</etal></person-group> (<year>2021</year>) <article-title>Unveiling the sensory and interneuronal pathways of the neuroendocrine connectome in Drosophila</article-title>. <source>Elife</source> <volume>10</volume>:<elocation-id>e65745</elocation-id></mixed-citation></ref>
+<ref id="c6"><label>6.</label><mixed-citation publication-type="journal"><person-group person-group-type="author"><string-name><surname>Huckesfeld</surname> <given-names>S</given-names></string-name>, <etal>et al</etal></person-group> (<year>2021</year>) <article-title>Unveiling the sensory and interneuronal pathways of the neuroendocrine connectome in Drosophila</article-title>. <source>eLife</source> <volume>10</volume>:<elocation-id>e65745</elocation-id></mixed-citation></ref>
 <ref id="c7"><label>7.</label><mixed-citation publication-type="journal"><person-group person-group-type="author"><string-name><surname>Huckesfeld</surname> <given-names>S</given-names></string-name>, <etal>et al</etal></person-group> (<year>2021</year>) <article-title>Unveiling the sensory and interneuronal pathways of the neuroendocrine connectome in Drosophila</article-title>. <source>eLife</source> <volume>10</volume>:<elocation-id>e65745</elocation-id></mixed-citation></ref>
 <ref id="c8"><label>8.</label><mixed-citation publication-type="journal"><person-group person-group-type="author"><string-name><surname>Huckesfeld</surname> <given-names>S</given-names></string-name>, <etal>et al</etal></person-group> (<year>2021</year>) <article-title>..</article-title>. <source>Plant Physiology</source> <volume>10</volume>:<elocation-id>e65745</elocation-id></mixed-citation></ref>
 </ref-list>
diff --git a/test/tests/preprint-changes/fix-common-ref-issues/output.xml b/test/tests/preprint-changes/fix-common-ref-issues/output.xml
index 89a62bb793..f4da74a1f7 100644
--- a/test/tests/preprint-changes/fix-common-ref-issues/output.xml
+++ b/test/tests/preprint-changes/fix-common-ref-issues/output.xml
@@ -4,5 +4,5 @@
 <ref id="c2"><label>2.</label><mixed-citation publication-type="journal"><person-group person-group-type="author"><string-name><surname>Ozbey</surname> <given-names>NP</given-names></string-name>, <etal>et al.</etal></person-group> <article-title>Tyramine Acts Downstream of Neuronal XBP-1s to Coordinate Inter-tissue UPR(ER) Activation and Behavior in C. elegans</article-title>. <source>Dev Cell</source> <volume>55</volume>, <fpage>754</fpage>–<lpage>770.e756</lpage> (<year>2020</year>). <pub-id pub-id-type="doi">10.1016/j.tibs.2017.08.001</pub-id></mixed-citation></ref>
 <ref id="c4"><label>4.</label><mixed-citation publication-type="book"><person-group person-group-type="author"><string-name><given-names>A.</given-names> <surname>Nagy</surname></string-name>, <string-name><given-names>M.</given-names> <surname>Gertsenstein</surname></string-name>, <string-name><given-names>K.</given-names> <surname>Vintersten</surname></string-name>, <string-name><given-names>R.</given-names> <surname>Behringer</surname></string-name></person-group>, <source>Manipulating the mouse embryo: a laboratory manual</source> (<publisher-name>Cold Spring Harbor Laboratory Press Cold Spring Harbor</publisher-name>, NY:, <year>2003</year>), vol. <volume>10</volume>.</mixed-citation></ref>
 <ref id="c5"><label>5.</label><mixed-citation publication-type="book"><person-group person-group-type="author"><string-name><given-names>J. M.</given-names> <surname>Glynn</surname></string-name>, <string-name><given-names>T. G.</given-names> <surname>Cotter</surname></string-name>, <string-name><given-names>D. R.</given-names> <surname>Green</surname></string-name></person-group> (<year>1992</year>) <source>Apoptosis induced by actinomycin D, camptothecin or aphidicolin can occur in all phases of the cell cycle</source>. (<publisher-loc>Portland</publisher-loc> <publisher-name>Press Ltd</publisher-name>.).</mixed-citation></ref>
-<ref id="c6"><label>6.</label><mixed-citation publication-type="journal"><person-group person-group-type="author"><string-name><surname>Huckesfeld</surname> <given-names>S</given-names></string-name>, <etal>et al</etal></person-group> (<year>2021</year>) <article-title>Unveiling the sensory and interneuronal pathways of the neuroendocrine connectome in Drosophila</article-title>. <source>Elife</source> <volume>10</volume>:<elocation-id>e65745</elocation-id></mixed-citation></ref>
+<ref id="c6"><label>6.</label><mixed-citation publication-type="journal"><person-group person-group-type="author"><string-name><surname>Huckesfeld</surname> <given-names>S</given-names></string-name>, <etal>et al</etal></person-group> (<year>2021</year>) <article-title>Unveiling the sensory and interneuronal pathways of the neuroendocrine connectome in Drosophila</article-title>. <source>eLife</source> <volume>10</volume>:<elocation-id>e65745</elocation-id></mixed-citation></ref>
 </ref-list>
\ No newline at end of file

From 1e3ed51c815d2b1bce4d4c030488cd096986845d Mon Sep 17 00:00:00 2001
From: Fred Atherden <43879983+fred-atherden@users.noreply.github.com>
Date: Mon, 17 Feb 2025 10:32:50 +0000
Subject: [PATCH 3/6] RP/VOR - tweak clintrial-related-object-8

---
 src/final-JATS-schematron.sch         | 2 +-
 src/final-JATS-schematron.xsl         | 6 +++---
 src/final-package-JATS-schematron.sch | 2 +-
 src/pre-JATS-schematron.sch           | 2 +-
 src/pre-JATS-schematron.xsl           | 6 +++---
 src/rp-schematron-base.sch            | 4 ++--
 src/rp-schematron.sch                 | 2 +-
 src/rp-schematron.xsl                 | 6 +++---
 src/schematron.sch                    | 4 ++--
 test/xspec/rp-schematron.sch          | 4 ++--
 test/xspec/schematron.sch             | 4 ++--
 11 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/src/final-JATS-schematron.sch b/src/final-JATS-schematron.sch
index a9289e52eb..6ff07ef94c 100644
--- a/src/final-JATS-schematron.sch
+++ b/src/final-JATS-schematron.sch
@@ -2256,7 +2256,7 @@
       
       <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-7" test="@xlink:href[not(matches(.,'\p{Zs}'))]" role="error" id="clintrial-related-object-7">[clintrial-related-object-7] <name/> must have an @xlink:href with a value that does not contain a space character.</assert>
       
-      <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-8" test="contains(.,@document-id/string())" role="warning" id="clintrial-related-object-8">[clintrial-related-object-8] <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not in the text, which is likely incorrect - <value-of select="."/>.</assert>
+      <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-8" test="@document-id = ." role="warning" id="clintrial-related-object-8">[clintrial-related-object-8] <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not the text of the related-object, which is likely incorrect - <value-of select="."/>.</assert>
       
       <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-9" test="matches(@id,'^RO[1-9]')" role="error" id="clintrial-related-object-9">[clintrial-related-object-9] <name/> must have an @id in the format 'RO1'. '<value-of select="@id"/>' does not conform to this convention.</assert>
       
diff --git a/src/final-JATS-schematron.xsl b/src/final-JATS-schematron.xsl
index 9abc7acea9..a16025aecf 100644
--- a/src/final-JATS-schematron.xsl
+++ b/src/final-JATS-schematron.xsl
@@ -11110,9 +11110,9 @@
       </xsl:choose>
       <!--ASSERT warning-->
       <xsl:choose>
-         <xsl:when test="contains(.,@document-id/string())"/>
+         <xsl:when test="@document-id = ."/>
          <xsl:otherwise>
-            <svrl:failed-assert xmlns:svrl="http://purl.oclc.org/dsdl/svrl" test="contains(.,@document-id/string())">
+            <svrl:failed-assert xmlns:svrl="http://purl.oclc.org/dsdl/svrl" test="@document-id = .">
                <xsl:attribute name="id">clintrial-related-object-8</xsl:attribute>
                <xsl:attribute name="see">https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-8</xsl:attribute>
                <xsl:attribute name="role">warning</xsl:attribute>
@@ -11123,7 +11123,7 @@
                   <xsl:value-of select="name(.)"/>
                   <xsl:text/> has an @document-id '<xsl:text/>
                   <xsl:value-of select="@document-id"/>
-                  <xsl:text/>'. But this is not in the text, which is likely incorrect - <xsl:text/>
+                  <xsl:text/>'. But this is not the text of the related-object, which is likely incorrect - <xsl:text/>
                   <xsl:value-of select="."/>
                   <xsl:text/>.</svrl:text>
             </svrl:failed-assert>
diff --git a/src/final-package-JATS-schematron.sch b/src/final-package-JATS-schematron.sch
index 333b3d7128..7157dfeedf 100644
--- a/src/final-package-JATS-schematron.sch
+++ b/src/final-package-JATS-schematron.sch
@@ -2262,7 +2262,7 @@
       
       <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-7" test="@xlink:href[not(matches(.,'\p{Zs}'))]" role="error" id="clintrial-related-object-7"><name/> must have an @xlink:href with a value that does not contain a space character.</assert>
       
-      <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-8" test="contains(.,@document-id/string())" role="warning" id="clintrial-related-object-8"><name/> has an @document-id '<value-of select="@document-id"/>'. But this is not in the text, which is likely incorrect - <value-of select="."/>.</assert>
+      <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-8" test="@document-id = ." role="warning" id="clintrial-related-object-8"><name/> has an @document-id '<value-of select="@document-id"/>'. But this is not the text of the related-object, which is likely incorrect - <value-of select="."/>.</assert>
       
       <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-9" test="matches(@id,'^RO[1-9]')" role="error" id="clintrial-related-object-9"><name/> must have an @id in the format 'RO1'. '<value-of select="@id"/>' does not conform to this convention.</assert>
       
diff --git a/src/pre-JATS-schematron.sch b/src/pre-JATS-schematron.sch
index b28efc4282..a453564355 100644
--- a/src/pre-JATS-schematron.sch
+++ b/src/pre-JATS-schematron.sch
@@ -2201,7 +2201,7 @@
       
       <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-7" test="@xlink:href[not(matches(.,'\p{Zs}'))]" role="error" id="clintrial-related-object-7">[clintrial-related-object-7] <name/> must have an @xlink:href with a value that does not contain a space character.</assert>
       
-      <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-8" test="contains(.,@document-id/string())" role="warning" id="clintrial-related-object-8">[clintrial-related-object-8] <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not in the text, which is likely incorrect - <value-of select="."/>.</assert>
+      <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-8" test="@document-id = ." role="warning" id="clintrial-related-object-8">[clintrial-related-object-8] <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not the text of the related-object, which is likely incorrect - <value-of select="."/>.</assert>
       
       <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-9" test="matches(@id,'^RO[1-9]')" role="error" id="clintrial-related-object-9">[clintrial-related-object-9] <name/> must have an @id in the format 'RO1'. '<value-of select="@id"/>' does not conform to this convention.</assert>
       
diff --git a/src/pre-JATS-schematron.xsl b/src/pre-JATS-schematron.xsl
index bcc7f04131..82b02baa0a 100644
--- a/src/pre-JATS-schematron.xsl
+++ b/src/pre-JATS-schematron.xsl
@@ -10957,9 +10957,9 @@
       </xsl:choose>
       <!--ASSERT warning-->
       <xsl:choose>
-         <xsl:when test="contains(.,@document-id/string())"/>
+         <xsl:when test="@document-id = ."/>
          <xsl:otherwise>
-            <svrl:failed-assert xmlns:svrl="http://purl.oclc.org/dsdl/svrl" test="contains(.,@document-id/string())">
+            <svrl:failed-assert xmlns:svrl="http://purl.oclc.org/dsdl/svrl" test="@document-id = .">
                <xsl:attribute name="id">clintrial-related-object-8</xsl:attribute>
                <xsl:attribute name="see">https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-8</xsl:attribute>
                <xsl:attribute name="role">warning</xsl:attribute>
@@ -10970,7 +10970,7 @@
                   <xsl:value-of select="name(.)"/>
                   <xsl:text/> has an @document-id '<xsl:text/>
                   <xsl:value-of select="@document-id"/>
-                  <xsl:text/>'. But this is not in the text, which is likely incorrect - <xsl:text/>
+                  <xsl:text/>'. But this is not the text of the related-object, which is likely incorrect - <xsl:text/>
                   <xsl:value-of select="."/>
                   <xsl:text/>.</svrl:text>
             </svrl:failed-assert>
diff --git a/src/rp-schematron-base.sch b/src/rp-schematron-base.sch
index 80b59ff84d..6eed72ff5e 100644
--- a/src/rp-schematron-base.sch
+++ b/src/rp-schematron-base.sch
@@ -2026,9 +2026,9 @@
         role="error" 
         id="clintrial-related-object-7"><name/> must have an @xlink:href with a value that does not contain a space character.</assert>
       
-      <assert test="contains(.,@document-id/string())" 
+      <assert test="@document-id = ." 
         role="warning" 
-        id="clintrial-related-object-8"><name/> has an @document-id '<value-of select="@document-id"/>'. But this is not in the text, which is likely incorrect - <value-of select="."/>.</assert>
+        id="clintrial-related-object-8"><name/> has an @document-id '<value-of select="@document-id"/>'. But this is not the text of the related-object, which is likely incorrect - <value-of select="."/>.</assert>
       
       <assert test="some $x in document($registries)/registries/registry satisfies ($x/subtitle/string()=@source-id)" 
         role="warning" 
diff --git a/src/rp-schematron.sch b/src/rp-schematron.sch
index eeda09357e..47e9b4cb2a 100644
--- a/src/rp-schematron.sch
+++ b/src/rp-schematron.sch
@@ -1071,7 +1071,7 @@
       
       <assert test="@xlink:href[not(matches(.,'\p{Zs}'))]" role="error" id="clintrial-related-object-7">[clintrial-related-object-7] <name/> must have an @xlink:href with a value that does not contain a space character.</assert>
       
-      <assert test="contains(.,@document-id/string())" role="warning" id="clintrial-related-object-8">[clintrial-related-object-8] <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not in the text, which is likely incorrect - <value-of select="."/>.</assert>
+      <assert test="@document-id = ." role="warning" id="clintrial-related-object-8">[clintrial-related-object-8] <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not the text of the related-object, which is likely incorrect - <value-of select="."/>.</assert>
       
       <assert test="some $x in document($registries)/registries/registry satisfies ($x/subtitle/string()=@source-id)" role="warning" id="clintrial-related-object-11">[clintrial-related-object-11] <name/> @source-id value should almost always be one of the subtitles of the Crossref clinical trial registries. "<value-of select="@source-id"/>" is not one of the following <value-of select="string-join(for $x in document($registries)/registries/registry return concat('&quot;',$x/subtitle/string(),'&quot; (',$x/doi/string(),')'),', ')"/>. Is that correct?</assert>
       
diff --git a/src/rp-schematron.xsl b/src/rp-schematron.xsl
index 279afdc1d5..5cc3b92d8b 100644
--- a/src/rp-schematron.xsl
+++ b/src/rp-schematron.xsl
@@ -7645,9 +7645,9 @@
       </xsl:choose>
       <!--ASSERT warning-->
       <xsl:choose>
-         <xsl:when test="contains(.,@document-id/string())"/>
+         <xsl:when test="@document-id = ."/>
          <xsl:otherwise>
-            <svrl:failed-assert xmlns:svrl="http://purl.oclc.org/dsdl/svrl" test="contains(.,@document-id/string())">
+            <svrl:failed-assert xmlns:svrl="http://purl.oclc.org/dsdl/svrl" test="@document-id = .">
                <xsl:attribute name="id">clintrial-related-object-8</xsl:attribute>
                <xsl:attribute name="role">warning</xsl:attribute>
                <xsl:attribute name="location">
@@ -7657,7 +7657,7 @@
                   <xsl:value-of select="name(.)"/>
                   <xsl:text/> has an @document-id '<xsl:text/>
                   <xsl:value-of select="@document-id"/>
-                  <xsl:text/>'. But this is not in the text, which is likely incorrect - <xsl:text/>
+                  <xsl:text/>'. But this is not the text of the related-object, which is likely incorrect - <xsl:text/>
                   <xsl:value-of select="."/>
                   <xsl:text/>.</svrl:text>
             </svrl:failed-assert>
diff --git a/src/schematron.sch b/src/schematron.sch
index 6ef55542b6..dfd946f4ea 100644
--- a/src/schematron.sch
+++ b/src/schematron.sch
@@ -3174,9 +3174,9 @@
         id="clintrial-related-object-7"><name/> must have an @xlink:href with a value that does not contain a space character.</assert>
       
       <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-8"
-        test="contains(.,@document-id/string())" 
+        test="@document-id = ." 
         role="warning" 
-        id="clintrial-related-object-8"><name/> has an @document-id '<value-of select="@document-id"/>'. But this is not in the text, which is likely incorrect - <value-of select="."/>.</assert>
+        id="clintrial-related-object-8"><name/> has an @document-id '<value-of select="@document-id"/>'. But this is not the text of the related-object, which is likely incorrect - <value-of select="."/>.</assert>
       
       <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-9"
         test="matches(@id,'^RO[1-9]')" 
diff --git a/test/xspec/rp-schematron.sch b/test/xspec/rp-schematron.sch
index d45b52245e..aa903efe90 100644
--- a/test/xspec/rp-schematron.sch
+++ b/test/xspec/rp-schematron.sch
@@ -1446,8 +1446,8 @@
       <assert test="@xlink:href[not(matches(.,'\p{Zs}'))]" role="error" id="clintrial-related-object-7">
         <name/> must have an @xlink:href with a value that does not contain a space character.</assert>
       
-      <assert test="contains(.,@document-id/string())" role="warning" id="clintrial-related-object-8">
-        <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not in the text, which is likely incorrect - <value-of select="."/>.</assert>
+      <assert test="@document-id = ." role="warning" id="clintrial-related-object-8">
+        <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not the text of the related-object, which is likely incorrect - <value-of select="."/>.</assert>
       
       <assert test="some $x in document($registries)/registries/registry satisfies ($x/subtitle/string()=@source-id)" role="warning" id="clintrial-related-object-11">
         <name/> @source-id value should almost always be one of the subtitles of the Crossref clinical trial registries. "<value-of select="@source-id"/>" is not one of the following <value-of select="string-join(for $x in document($registries)/registries/registry return concat('&quot;',$x/subtitle/string(),'&quot; (',$x/doi/string(),')'),', ')"/>. Is that correct?</assert>
diff --git a/test/xspec/schematron.sch b/test/xspec/schematron.sch
index c6dd046521..bd21b15256 100644
--- a/test/xspec/schematron.sch
+++ b/test/xspec/schematron.sch
@@ -2579,8 +2579,8 @@
       <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-7" test="@xlink:href[not(matches(.,'\p{Zs}'))]" role="error" id="clintrial-related-object-7">
         <name/> must have an @xlink:href with a value that does not contain a space character.</assert>
       
-      <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-8" test="contains(.,@document-id/string())" role="warning" id="clintrial-related-object-8">
-        <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not in the text, which is likely incorrect - <value-of select="."/>.</assert>
+      <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-8" test="@document-id = ." role="warning" id="clintrial-related-object-8">
+        <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not the text of the related-object, which is likely incorrect - <value-of select="."/>.</assert>
       
       <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-9" test="matches(@id,'^RO[1-9]')" role="error" id="clintrial-related-object-9">
         <name/> must have an @id in the format 'RO1'. '<value-of select="@id"/>' does not conform to this convention.</assert>

From 1a6b5778cdf6bf8e46619ffaab533eb734f783f7 Mon Sep 17 00:00:00 2001
From: Fred Atherden <43879983+fred-atherden@users.noreply.github.com>
Date: Mon, 17 Feb 2025 10:34:19 +0000
Subject: [PATCH 4/6] Update test cases

---
 .../clintrial-related-object-8/clintrial-related-object-8.sch | 4 ++--
 .../clintrial-related-object-8/fail.xml                       | 4 ++--
 .../clintrial-related-object-8/pass.xml                       | 4 ++--
 .../clintrial-related-object-8/clintrial-related-object-8.sch | 2 +-
 .../clintrial-related-object-8/fail.xml                       | 4 ++--
 .../clintrial-related-object-8/pass.xml                       | 4 ++--
 6 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/test/tests/gen/clintrial-related-object/clintrial-related-object-8/clintrial-related-object-8.sch b/test/tests/gen/clintrial-related-object/clintrial-related-object-8/clintrial-related-object-8.sch
index 4506498d52..8a6869daea 100644
--- a/test/tests/gen/clintrial-related-object/clintrial-related-object-8/clintrial-related-object-8.sch
+++ b/test/tests/gen/clintrial-related-object/clintrial-related-object-8/clintrial-related-object-8.sch
@@ -1363,8 +1363,8 @@
   <pattern id="article-metadata">
     <rule context="abstract[not(@abstract-type) and sec]//related-object" id="clintrial-related-object">
       <let name="registries" value="'../../../../../src/clinical-trial-registries.xml'"/>
-      <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-8" test="contains(.,@document-id/string())" role="warning" id="clintrial-related-object-8">
-        <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not in the text, which is likely incorrect - <value-of select="."/>.</assert>
+      <assert see="https://elifeproduction.slab.com/posts/abstracts-digests-and-impact-statements-tiau2k6x#clintrial-related-object-8" test="@document-id = ." role="warning" id="clintrial-related-object-8">
+        <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not the text of the related-object, which is likely incorrect - <value-of select="."/>.</assert>
     </rule>
   </pattern>
   <pattern id="root-pattern">
diff --git a/test/tests/gen/clintrial-related-object/clintrial-related-object-8/fail.xml b/test/tests/gen/clintrial-related-object/clintrial-related-object-8/fail.xml
index 8e78228bdb..f679b3beaa 100644
--- a/test/tests/gen/clintrial-related-object/clintrial-related-object-8/fail.xml
+++ b/test/tests/gen/clintrial-related-object/clintrial-related-object-8/fail.xml
@@ -1,7 +1,7 @@
 <?oxygen SCHSchema="clintrial-related-object-8.sch"?>
 <!--Context: abstract[not(@abstract-type) and sec]//related-object
-Test: assert    contains(.,@document-id/string())
-Message:  has an @document-id ''. But this is not in the text, which is likely incorrect - . -->
+Test: assert    @document-id = .
+Message:  has an @document-id ''. But this is not the text of the related-object, which is likely incorrect - . -->
 <root xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:ali="http://www.niso.org/schemas/ali/1.0/">
   <article>
     <front>
diff --git a/test/tests/gen/clintrial-related-object/clintrial-related-object-8/pass.xml b/test/tests/gen/clintrial-related-object/clintrial-related-object-8/pass.xml
index 8f894ca6c8..85541a5434 100644
--- a/test/tests/gen/clintrial-related-object/clintrial-related-object-8/pass.xml
+++ b/test/tests/gen/clintrial-related-object/clintrial-related-object-8/pass.xml
@@ -1,7 +1,7 @@
 <?oxygen SCHSchema="clintrial-related-object-8.sch"?>
 <!--Context: abstract[not(@abstract-type) and sec]//related-object
-Test: assert    contains(.,@document-id/string())
-Message:  has an @document-id ''. But this is not in the text, which is likely incorrect - . -->
+Test: assert    @document-id = .
+Message:  has an @document-id ''. But this is not the text of the related-object, which is likely incorrect - . -->
 <root xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:ali="http://www.niso.org/schemas/ali/1.0/">
   <article>
     <front>
diff --git a/test/tests/rp/clintrial-related-object/clintrial-related-object-8/clintrial-related-object-8.sch b/test/tests/rp/clintrial-related-object/clintrial-related-object-8/clintrial-related-object-8.sch
index fd1883b90a..41fecd51fc 100644
--- a/test/tests/rp/clintrial-related-object/clintrial-related-object-8/clintrial-related-object-8.sch
+++ b/test/tests/rp/clintrial-related-object/clintrial-related-object-8/clintrial-related-object-8.sch
@@ -147,7 +147,7 @@
   <pattern id="clintrial-related-object-pattern">
     <rule context="related-object[@content-type or @document-id]" id="clintrial-related-object">
       <let name="registries" value="'../../../../../src/clinical-trial-registries.xml'"/>
-      <assert test="contains(.,@document-id/string())" role="warning" id="clintrial-related-object-8">[clintrial-related-object-8] <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not in the text, which is likely incorrect - <value-of select="."/>.</assert>
+      <assert test="@document-id = ." role="warning" id="clintrial-related-object-8">[clintrial-related-object-8] <name/> has an @document-id '<value-of select="@document-id"/>'. But this is not the text of the related-object, which is likely incorrect - <value-of select="."/>.</assert>
     </rule>
   </pattern>
   <pattern id="root-pattern">
diff --git a/test/tests/rp/clintrial-related-object/clintrial-related-object-8/fail.xml b/test/tests/rp/clintrial-related-object/clintrial-related-object-8/fail.xml
index d7ab104843..2b17be9c69 100644
--- a/test/tests/rp/clintrial-related-object/clintrial-related-object-8/fail.xml
+++ b/test/tests/rp/clintrial-related-object/clintrial-related-object-8/fail.xml
@@ -1,7 +1,7 @@
 <?oxygen SCHSchema="clintrial-related-object-8.sch"?>
 <!--Context: related-object[@content-type or @document-id]
-Test: assert    contains(.,@document-id/string())
-Message:  has an @document-id ''. But this is not in the text, which is likely incorrect - . -->
+Test: assert    @document-id = .
+Message:  has an @document-id ''. But this is not the text of the related-object, which is likely incorrect - . -->
 <root xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:ali="http://www.niso.org/schemas/ali/1.0/">
   <article>
     <front>
diff --git a/test/tests/rp/clintrial-related-object/clintrial-related-object-8/pass.xml b/test/tests/rp/clintrial-related-object/clintrial-related-object-8/pass.xml
index 7bc7186872..dbdce95141 100644
--- a/test/tests/rp/clintrial-related-object/clintrial-related-object-8/pass.xml
+++ b/test/tests/rp/clintrial-related-object/clintrial-related-object-8/pass.xml
@@ -1,7 +1,7 @@
 <?oxygen SCHSchema="clintrial-related-object-8.sch"?>
 <!--Context: related-object[@content-type or @document-id]
-Test: assert    contains(.,@document-id/string())
-Message:  has an @document-id ''. But this is not in the text, which is likely incorrect - . -->
+Test: assert    @document-id = .
+Message:  has an @document-id ''. But this is not the text of the related-object, which is likely incorrect - . -->
 <root xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:ali="http://www.niso.org/schemas/ali/1.0/">
   <article>
     <front>

From 2c09239ad55c9cbed48c58ca21c3c7fd053cbcce Mon Sep 17 00:00:00 2001
From: Fred Atherden <43879983+fred-atherden@users.noreply.github.com>
Date: Mon, 17 Feb 2025 10:42:00 +0000
Subject: [PATCH 5/6] Update actual relevant test cases

---
 .../clintrial-related-object-8/fail.xml                         | 2 +-
 .../clintrial-related-object-8/pass.xml                         | 2 +-
 .../clintrial-related-object-8/fail.xml                         | 2 +-
 .../clintrial-related-object-8/pass.xml                         | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/test/tests/gen/clintrial-related-object/clintrial-related-object-8/fail.xml b/test/tests/gen/clintrial-related-object/clintrial-related-object-8/fail.xml
index f679b3beaa..f9a7e0f600 100644
--- a/test/tests/gen/clintrial-related-object/clintrial-related-object-8/fail.xml
+++ b/test/tests/gen/clintrial-related-object/clintrial-related-object-8/fail.xml
@@ -26,7 +26,7 @@ Message:  has an @document-id ''. But this is not the text of the related-object
           </sec>
           <sec id="abs6">
             <title>Clinical trial number:</title>
-            <p><related-object id="RO1" source-type="clinical-trials-registry" source-id="ClinicalTrials.gov" source-id-type="registry-name" document-id="NCT02968459" document-id-type="clinical-trial-number" xlink:href="https://clinicaltrials.gov/show/NCT02968459">bjirpebwivtprbwuip.</related-object></p>
+            <p><related-object id="RO1" source-type="clinical-trials-registry" source-id="ClinicalTrials.gov" source-id-type="registry-name" document-id="NCT02968459" document-id-type="clinical-trial-number" xlink:href="https://clinicaltrials.gov/show/NCT02968459">bjirpebwivtprbwuip</related-object>.</p>
           </sec>
         </abstract>
       </article-meta>
diff --git a/test/tests/gen/clintrial-related-object/clintrial-related-object-8/pass.xml b/test/tests/gen/clintrial-related-object/clintrial-related-object-8/pass.xml
index 85541a5434..4dd01f10b3 100644
--- a/test/tests/gen/clintrial-related-object/clintrial-related-object-8/pass.xml
+++ b/test/tests/gen/clintrial-related-object/clintrial-related-object-8/pass.xml
@@ -26,7 +26,7 @@ Message:  has an @document-id ''. But this is not the text of the related-object
           </sec>
           <sec id="abs6">
             <title>Clinical trial number:</title>
-            <p><related-object id="RO1" source-type="clinical-trials-registry" source-id="ClinicalTrials.gov" source-id-type="registry-name" document-id="NCT02968459" document-id-type="clinical-trial-number" xlink:href="https://clinicaltrials.gov/show/NCT02968459">NCT02968459.</related-object></p>
+            <p><related-object id="RO1" source-type="clinical-trials-registry" source-id="ClinicalTrials.gov" source-id-type="registry-name" document-id="NCT02968459" document-id-type="clinical-trial-number" xlink:href="https://clinicaltrials.gov/show/NCT02968459">NCT02968459</related-object>.</p>
           </sec>
         </abstract>
       </article-meta>
diff --git a/test/tests/rp/clintrial-related-object/clintrial-related-object-8/fail.xml b/test/tests/rp/clintrial-related-object/clintrial-related-object-8/fail.xml
index 2b17be9c69..6aca27846f 100644
--- a/test/tests/rp/clintrial-related-object/clintrial-related-object-8/fail.xml
+++ b/test/tests/rp/clintrial-related-object/clintrial-related-object-8/fail.xml
@@ -26,7 +26,7 @@ Message:  has an @document-id ''. But this is not the text of the related-object
           </sec>
           <sec id="abs6">
             <title>Clinical trial number:</title>
-            <p><related-object id="RO1" source-type="clinical-trials-registry" source-id="ClinicalTrials.gov" source-id-type="registry-name" document-id="NCT02968459" document-id-type="clinical-trial-number" xlink:href="https://clinicaltrials.gov/show/NCT02968459">bjirpebwivtprbwuip.</related-object></p>
+            <p><related-object id="RO1" source-type="clinical-trials-registry" source-id="ClinicalTrials.gov" source-id-type="registry-name" document-id="NCT02968459" document-id-type="clinical-trial-number" xlink:href="https://clinicaltrials.gov/show/NCT02968459">bjirpebwivtprbwuip</related-object>.</p>
           </sec>
         </abstract>
       </article-meta>
diff --git a/test/tests/rp/clintrial-related-object/clintrial-related-object-8/pass.xml b/test/tests/rp/clintrial-related-object/clintrial-related-object-8/pass.xml
index dbdce95141..8d98014c8c 100644
--- a/test/tests/rp/clintrial-related-object/clintrial-related-object-8/pass.xml
+++ b/test/tests/rp/clintrial-related-object/clintrial-related-object-8/pass.xml
@@ -26,7 +26,7 @@ Message:  has an @document-id ''. But this is not the text of the related-object
           </sec>
           <sec id="abs6">
             <title>Clinical trial number:</title>
-            <p><related-object id="RO1" source-type="clinical-trials-registry" source-id="ClinicalTrials.gov" source-id-type="registry-name" document-id="NCT02968459" document-id-type="clinical-trial-number" xlink:href="https://clinicaltrials.gov/show/NCT02968459">NCT02968459.</related-object></p>
+            <p><related-object id="RO1" source-type="clinical-trials-registry" source-id="ClinicalTrials.gov" source-id-type="registry-name" document-id="NCT02968459" document-id-type="clinical-trial-number" xlink:href="https://clinicaltrials.gov/show/NCT02968459">NCT02968459</related-object>.</p>
           </sec>
         </abstract>
       </article-meta>

From 489f2b9a7c37b4bdb0480c1e4972b51ba7b1f0ea Mon Sep 17 00:00:00 2001
From: Fred Atherden <43879983+fred-atherden@users.noreply.github.com>
Date: Mon, 17 Feb 2025 12:38:57 +0000
Subject: [PATCH 6/6] RP - error for preprint ref w/ volume

---
 src/rp-schematron-base.sch                    |   4 +
 src/rp-schematron.sch                         |   2 +
 src/rp-schematron.xsl                         |  15 ++
 .../preprint-ref-volume/fail.xml              |  11 ++
 .../preprint-ref-volume/pass.xml              |   9 +
 .../preprint-ref-volume.sch                   | 157 ++++++++++++++++++
 test/xspec/rp-schematron.sch                  |   2 +
 test/xspec/rp-schematron.xspec                |  10 ++
 8 files changed, 210 insertions(+)
 create mode 100644 test/tests/rp/preprint-ref-checks/preprint-ref-volume/fail.xml
 create mode 100644 test/tests/rp/preprint-ref-checks/preprint-ref-volume/pass.xml
 create mode 100644 test/tests/rp/preprint-ref-checks/preprint-ref-volume/preprint-ref-volume.sch

diff --git a/src/rp-schematron-base.sch b/src/rp-schematron-base.sch
index 6eed72ff5e..a4638891bc 100644
--- a/src/rp-schematron-base.sch
+++ b/src/rp-schematron-base.sch
@@ -579,6 +579,10 @@
         <report test="text()[matches(.,'\p{L}') and not(matches(lower-case(.),'^[\p{Z}\p{P}]+(doi|pmid|and|pp?)[:\.]?'))]" 
         role="warning" 
         id="preprint-ref-text-content">This preprint reference (<value-of select="if (ancestor::ref/@id) then concat('id ',ancestor::ref/@id) else 'no id'"/>) has untagged textual content - <value-of select="string-join(text()[matches(.,'\p{L}') and not(matches(lower-case(.),'^[\p{Z}\p{P}]+(doi|pmid|and|pp?)[:\.]?'))],'; ')"/>. Is it tagged correctly?</report>
+       
+       <report test="volume" 
+        role="error" 
+        id="preprint-ref-volume">This preprint reference (<value-of select="if (ancestor::ref/@id) then concat('id ',ancestor::ref/@id) else 'no id'"/>) has a volume - <value-of select="volume"/>. That information is either tagged incorrectly, or the publication-type is wrong.</report>
      </rule>
       
       <rule context="mixed-citation[@publication-type='preprint']/source" id="preprint-source-checks">
diff --git a/src/rp-schematron.sch b/src/rp-schematron.sch
index 47e9b4cb2a..515056f51b 100644
--- a/src/rp-schematron.sch
+++ b/src/rp-schematron.sch
@@ -363,6 +363,8 @@
         <assert test="article-title" role="error" id="preprint-ref-article-title">[preprint-ref-article-title] This preprint reference (<value-of select="if (ancestor::ref/@id) then concat('id ',ancestor::ref/@id) else 'no id'"/>) has no article-title element.</assert>
 
         <report test="text()[matches(.,'\p{L}') and not(matches(lower-case(.),'^[\p{Z}\p{P}]+(doi|pmid|and|pp?)[:\.]?'))]" role="warning" id="preprint-ref-text-content">[preprint-ref-text-content] This preprint reference (<value-of select="if (ancestor::ref/@id) then concat('id ',ancestor::ref/@id) else 'no id'"/>) has untagged textual content - <value-of select="string-join(text()[matches(.,'\p{L}') and not(matches(lower-case(.),'^[\p{Z}\p{P}]+(doi|pmid|and|pp?)[:\.]?'))],'; ')"/>. Is it tagged correctly?</report>
+       
+       <report test="volume" role="error" id="preprint-ref-volume">[preprint-ref-volume] This preprint reference (<value-of select="if (ancestor::ref/@id) then concat('id ',ancestor::ref/@id) else 'no id'"/>) has a volume - <value-of select="volume"/>. That information is either tagged incorrectly, or the publication-type is wrong.</report>
      </rule></pattern><pattern id="preprint-source-checks-pattern"><rule context="mixed-citation[@publication-type='preprint']/source" id="preprint-source-checks">
         <report test="matches(lower-case(.),'^(\.\s*)?in[^a-z]')" role="warning" id="preprint-source">[preprint-source] Preprint reference (<value-of select="if (ancestor::ref/@id) then concat('id ',ancestor::ref/@id) else 'no id'"/>) has a source that starts with 'In ', '<value-of select="."/>'. Should that text be moved out of the source? And is it a different type of reference?</report>
         
diff --git a/src/rp-schematron.xsl b/src/rp-schematron.xsl
index 5cc3b92d8b..7fbae082a7 100644
--- a/src/rp-schematron.xsl
+++ b/src/rp-schematron.xsl
@@ -2885,6 +2885,21 @@
                <xsl:text/>. Is it tagged correctly?</svrl:text>
          </svrl:successful-report>
       </xsl:if>
+      <!--REPORT error-->
+      <xsl:if test="volume">
+         <svrl:successful-report xmlns:svrl="http://purl.oclc.org/dsdl/svrl" test="volume">
+            <xsl:attribute name="id">preprint-ref-volume</xsl:attribute>
+            <xsl:attribute name="role">error</xsl:attribute>
+            <xsl:attribute name="location">
+               <xsl:apply-templates select="." mode="schematron-select-full-path"/>
+            </xsl:attribute>
+            <svrl:text>[preprint-ref-volume] This preprint reference (<xsl:text/>
+               <xsl:value-of select="if (ancestor::ref/@id) then concat('id ',ancestor::ref/@id) else 'no id'"/>
+               <xsl:text/>) has a volume - <xsl:text/>
+               <xsl:value-of select="volume"/>
+               <xsl:text/>. That information is either tagged incorrectly, or the publication-type is wrong.</svrl:text>
+         </svrl:successful-report>
+      </xsl:if>
       <xsl:apply-templates select="*" mode="M35"/>
    </xsl:template>
    <xsl:template match="text()" priority="-1" mode="M35"/>
diff --git a/test/tests/rp/preprint-ref-checks/preprint-ref-volume/fail.xml b/test/tests/rp/preprint-ref-checks/preprint-ref-volume/fail.xml
new file mode 100644
index 0000000000..874a4a3658
--- /dev/null
+++ b/test/tests/rp/preprint-ref-checks/preprint-ref-volume/fail.xml
@@ -0,0 +1,11 @@
+<?oxygen SCHSchema="preprint-ref-volume.sch"?>
+<!--Context: mixed-citation[@publication-type='preprint']
+Test: report    volume
+Message: This preprint reference () has a volume - . That information is either tagged incorrectly, or the publication-type is wrong. -->
+<root xmlns:ali="http://www.niso.org/schemas/ali/1.0/" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:xlink="http://www.w3.org/1999/xlink">
+    <article>
+        <mixed-citation publication-type="preprint">
+            <volume/>
+        </mixed-citation>
+    </article>
+</root>
\ No newline at end of file
diff --git a/test/tests/rp/preprint-ref-checks/preprint-ref-volume/pass.xml b/test/tests/rp/preprint-ref-checks/preprint-ref-volume/pass.xml
new file mode 100644
index 0000000000..0f1281e28c
--- /dev/null
+++ b/test/tests/rp/preprint-ref-checks/preprint-ref-volume/pass.xml
@@ -0,0 +1,9 @@
+<?oxygen SCHSchema="preprint-ref-volume.sch"?>
+<!--Context: mixed-citation[@publication-type='preprint']
+Test: report    volume
+Message: This preprint reference () has a volume - . That information is either tagged incorrectly, or the publication-type is wrong. -->
+<root xmlns:ali="http://www.niso.org/schemas/ali/1.0/" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:xlink="http://www.w3.org/1999/xlink">
+    <article>
+        <mixed-citation publication-type="preprint"/>
+    </article>
+</root>
\ No newline at end of file
diff --git a/test/tests/rp/preprint-ref-checks/preprint-ref-volume/preprint-ref-volume.sch b/test/tests/rp/preprint-ref-checks/preprint-ref-volume/preprint-ref-volume.sch
new file mode 100644
index 0000000000..02dcbcf064
--- /dev/null
+++ b/test/tests/rp/preprint-ref-checks/preprint-ref-volume/preprint-ref-volume.sch
@@ -0,0 +1,157 @@
+<schema xmlns="http://purl.oclc.org/dsdl/schematron" xmlns:meca="http://manuscriptexchange.org" xmlns:mml="http://www.w3.org/1998/Math/MathML" xmlns:ali="http://www.niso.org/schemas/ali/1.0/" xmlns:file="java.io.File" xmlns:java="http://www.java.com/" xmlns:xsl="http://www.w3.org/1999/XSL/Transform" xmlns:xlink="http://www.w3.org/1999/xlink" queryBinding="xslt2">
+  <title>eLife reviewed preprint schematron</title>
+  <ns uri="http://www.niso.org/schemas/ali/1.0/" prefix="ali"/>
+  <ns uri="http://www.w3.org/XML/1998/namespace" prefix="xml"/>
+  <ns uri="http://www.w3.org/1999/xlink" prefix="xlink"/>
+  <ns uri="http://www.w3.org/2001/XInclude" prefix="xi"/>
+  <ns uri="http://www.w3.org/1998/Math/MathML" prefix="mml"/>
+  <ns uri="http://saxon.sf.net/" prefix="saxon"/>
+  <ns uri="http://purl.org/dc/terms/" prefix="dc"/>
+  <ns uri="http://www.w3.org/2001/XMLSchema" prefix="xs"/>
+  <ns uri="https://elifesciences.org/namespace" prefix="e"/>
+  <ns uri="java.io.File" prefix="file"/>
+  <ns uri="http://www.java.com/" prefix="java"/>
+  <ns uri="http://manuscriptexchange.org" prefix="meca"/>
+  <xsl:function name="e:isbn-sum" as="xs:integer">
+    <xsl:param name="s" as="xs:string"/>
+    <xsl:choose>
+      <xsl:when test="string-length($s) = 10">
+        <xsl:variable name="d1" select="number(substring($s,1,1)) * 10"/>
+        <xsl:variable name="d2" select="number(substring($s,2,1)) * 9"/>
+        <xsl:variable name="d3" select="number(substring($s,3,1)) * 8"/>
+        <xsl:variable name="d4" select="number(substring($s,4,1)) * 7"/>
+        <xsl:variable name="d5" select="number(substring($s,5,1)) * 6"/>
+        <xsl:variable name="d6" select="number(substring($s,6,1)) * 5"/>
+        <xsl:variable name="d7" select="number(substring($s,7,1)) * 4"/>
+        <xsl:variable name="d8" select="number(substring($s,8,1)) * 3"/>
+        <xsl:variable name="d9" select="number(substring($s,9,1)) * 2"/>
+        <xsl:variable name="d10" select="number(substring($s,10,1)) * 1"/>
+        <xsl:value-of select="number($d1 + $d2 + $d3 + $d4 + $d5 + $d6 + $d7 + $d8 + $d9 + $d10) mod 11"/>
+      </xsl:when>
+      <xsl:when test="string-length($s) = 13">
+        <xsl:variable name="d1" select="number(substring($s,1,1))"/>
+        <xsl:variable name="d2" select="number(substring($s,2,1)) * 3"/>
+        <xsl:variable name="d3" select="number(substring($s,3,1))"/>
+        <xsl:variable name="d4" select="number(substring($s,4,1)) * 3"/>
+        <xsl:variable name="d5" select="number(substring($s,5,1))"/>
+        <xsl:variable name="d6" select="number(substring($s,6,1)) * 3"/>
+        <xsl:variable name="d7" select="number(substring($s,7,1))"/>
+        <xsl:variable name="d8" select="number(substring($s,8,1)) * 3"/>
+        <xsl:variable name="d9" select="number(substring($s,9,1))"/>
+        <xsl:variable name="d10" select="number(substring($s,10,1)) * 3"/>
+        <xsl:variable name="d11" select="number(substring($s,11,1))"/>
+        <xsl:variable name="d12" select="number(substring($s,12,1)) * 3"/>
+        <xsl:variable name="d13" select="number(substring($s,13,1))"/>
+        <xsl:value-of select="number($d1 + $d2 + $d3 + $d4 + $d5 + $d6 + $d7 + $d8 + $d9 + $d10 + $d11 + $d12 + $d13) mod 10"/>
+      </xsl:when>
+      <xsl:otherwise>
+        <xsl:value-of select="number('1')"/>
+      </xsl:otherwise>
+    </xsl:choose>
+  </xsl:function>
+  <xsl:function name="e:is-valid-issn" as="xs:boolean">
+      <xsl:param name="s" as="xs:string"/>
+      <xsl:choose>
+        <xsl:when test="not(matches($s,'^\d{4}\-\d{3}[\dX]$'))">
+          <xsl:value-of select="false()"/>
+        </xsl:when>
+        <xsl:otherwise>
+            <xsl:variable name="d1" select="number(substring($s,1,1)) * 8"/>
+            <xsl:variable name="d2" select="number(substring($s,2,1)) * 7"/>
+            <xsl:variable name="d3" select="number(substring($s,3,1)) * 6"/>
+            <xsl:variable name="d4" select="number(substring($s,4,1)) * 5"/>
+            <xsl:variable name="d5" select="number(substring($s,6,1)) * 4"/>
+            <xsl:variable name="d6" select="number(substring($s,7,1)) * 3"/>
+            <xsl:variable name="d7" select="number(substring($s,8,1)) * 2"/>
+            <xsl:variable name="remainder" select="number($d1 + $d2 + $d3 + $d4 + $d5 + $d6 + $d7) mod 11"/>
+            <xsl:variable name="calc" select="if ($remainder=0) then 0 else (11 - $remainder)"/>
+            <xsl:variable name="check" select="if (substring($s,9,1)='X') then 10 else number(substring($s,9,1))"/>
+            <xsl:value-of select="$calc = $check"/>
+        </xsl:otherwise>
+      </xsl:choose>
+    </xsl:function>
+  <xsl:function name="e:get-name" as="xs:string">
+    <xsl:param name="name"/>
+    <xsl:choose>
+      <xsl:when test="$name/given-names[1] and $name/surname[1] and $name/suffix[1]">
+        <xsl:value-of select="concat($name/given-names[1],' ',$name/surname[1],' ',$name/suffix[1])"/>
+      </xsl:when>
+      <xsl:when test="not($name/given-names[1]) and $name/surname[1] and $name/suffix[1]">
+        <xsl:value-of select="concat($name/surname[1],' ',$name/suffix[1])"/>
+      </xsl:when>
+      <xsl:when test="$name/given-names[1] and $name/surname[1] and not($name/suffix[1])">
+        <xsl:value-of select="concat($name/given-names[1],' ',$name/surname[1])"/>
+      </xsl:when>
+      <xsl:when test="not($name/given-names[1]) and $name/surname[1] and not($name/suffix[1])">
+        <xsl:value-of select="$name/surname[1]"/>
+      </xsl:when>
+      <xsl:otherwise>
+        <xsl:value-of select="'No elements present'"/>
+      </xsl:otherwise>
+    </xsl:choose>
+  </xsl:function>
+  <xsl:function name="e:get-copyright-holder">
+    <xsl:param name="contrib-group"/>
+    <xsl:variable name="author-count" select="count($contrib-group/contrib[@contrib-type='author'])"/>
+    <xsl:choose>
+      <xsl:when test="$author-count lt 1"/>
+      <xsl:when test="$author-count = 1">
+        <xsl:choose>
+          <xsl:when test="$contrib-group/contrib[@contrib-type='author']/collab">
+            <xsl:value-of select="$contrib-group/contrib[@contrib-type='author']/collab[1]/text()[1]"/>
+          </xsl:when>
+          <xsl:otherwise>
+            <xsl:value-of select="$contrib-group/contrib[@contrib-type='author']/name[1]/surname[1]"/>
+          </xsl:otherwise>
+        </xsl:choose>
+      </xsl:when>
+      <xsl:when test="$author-count = 2">
+        <xsl:choose>
+          <xsl:when test="$contrib-group/contrib[@contrib-type='author']/collab">
+            <xsl:choose>
+              <xsl:when test="$contrib-group/contrib[@contrib-type='author'][1]/collab and $contrib-group/contrib[@contrib-type='author'][2]/collab">
+                <xsl:value-of select="concat($contrib-group/contrib[@contrib-type='author']/collab[1]/text()[1],' &amp; ',$contrib-group/contrib[@contrib-type='author']/collab[2]/text()[1])"/>
+              </xsl:when>
+              <xsl:when test="$contrib-group/contrib[@contrib-type='author'][1]/collab">
+                <xsl:value-of select="concat($contrib-group/contrib[@contrib-type='author'][1]/collab[1]/text()[1],' &amp; ',$contrib-group/contrib[@contrib-type='author'][2]/name[1]/surname[1])"/>
+              </xsl:when>
+              <xsl:otherwise>
+                <xsl:value-of select="concat($contrib-group/contrib[@contrib-type='author'][1]/name[1]/surname[1],' &amp; ',$contrib-group/contrib[@contrib-type='author'][2]/collab[1]/text()[1])"/>
+              </xsl:otherwise>
+            </xsl:choose>
+          </xsl:when>
+          <xsl:otherwise>
+            <xsl:value-of select="concat($contrib-group/contrib[@contrib-type='author'][1]/name[1]/surname[1],' &amp; ',$contrib-group/contrib[@contrib-type='author'][2]/name[1]/surname[1])"/>
+          </xsl:otherwise>
+        </xsl:choose>
+      </xsl:when>
+      
+      <xsl:otherwise>
+        <xsl:variable name="is-equal-contrib" select="if ($contrib-group/contrib[@contrib-type='author'][1]/@equal-contrib='yes') then true() else false()"/>
+        
+        <xsl:value-of select="concat(e:get-surname($contrib-group/contrib[@contrib-type='author'][1]),' et al')"/>
+      </xsl:otherwise>
+    </xsl:choose>
+  </xsl:function>
+  <xsl:function name="e:get-surname" as="text()">
+    <xsl:param name="contrib"/>
+    <xsl:choose>
+      <xsl:when test="$contrib/collab">
+        <xsl:value-of select="$contrib/collab[1]/text()[1]"/>
+      </xsl:when>
+      <xsl:otherwise>
+        <xsl:value-of select="$contrib//name[1]/surname[1]"/>
+      </xsl:otherwise>
+    </xsl:choose>
+  </xsl:function>
+  <pattern id="preprint-ref-checks-pattern">
+    <rule context="mixed-citation[@publication-type='preprint']" id="preprint-ref-checks">
+      <report test="volume" role="error" id="preprint-ref-volume">[preprint-ref-volume] This preprint reference (<value-of select="if (ancestor::ref/@id) then concat('id ',ancestor::ref/@id) else 'no id'"/>) has a volume - <value-of select="volume"/>. That information is either tagged incorrectly, or the publication-type is wrong.</report>
+    </rule>
+  </pattern>
+  <pattern id="root-pattern">
+    <rule context="root" id="root-rule">
+      <assert test="descendant::mixed-citation[@publication-type='preprint']" role="error" id="preprint-ref-checks-xspec-assert">mixed-citation[@publication-type='preprint'] must be present.</assert>
+    </rule>
+  </pattern>
+</schema>
\ No newline at end of file
diff --git a/test/xspec/rp-schematron.sch b/test/xspec/rp-schematron.sch
index aa903efe90..22b6e2463a 100644
--- a/test/xspec/rp-schematron.sch
+++ b/test/xspec/rp-schematron.sch
@@ -422,6 +422,8 @@
         <assert test="article-title" role="error" id="preprint-ref-article-title">This preprint reference (<value-of select="if (ancestor::ref/@id) then concat('id ',ancestor::ref/@id) else 'no id'"/>) has no article-title element.</assert>
 
         <report test="text()[matches(.,'\p{L}') and not(matches(lower-case(.),'^[\p{Z}\p{P}]+(doi|pmid|and|pp?)[:\.]?'))]" role="warning" id="preprint-ref-text-content">This preprint reference (<value-of select="if (ancestor::ref/@id) then concat('id ',ancestor::ref/@id) else 'no id'"/>) has untagged textual content - <value-of select="string-join(text()[matches(.,'\p{L}') and not(matches(lower-case(.),'^[\p{Z}\p{P}]+(doi|pmid|and|pp?)[:\.]?'))],'; ')"/>. Is it tagged correctly?</report>
+       
+       <report test="volume" role="error" id="preprint-ref-volume">This preprint reference (<value-of select="if (ancestor::ref/@id) then concat('id ',ancestor::ref/@id) else 'no id'"/>) has a volume - <value-of select="volume"/>. That information is either tagged incorrectly, or the publication-type is wrong.</report>
      </rule>
   </pattern>
   <pattern id="preprint-source-checks-pattern">
diff --git a/test/xspec/rp-schematron.xspec b/test/xspec/rp-schematron.xspec
index 3d2945c83a..57ba54d8c1 100644
--- a/test/xspec/rp-schematron.xspec
+++ b/test/xspec/rp-schematron.xspec
@@ -845,6 +845,16 @@
         <x:expect-report id="preprint-ref-text-content" role="warning"/>
         <x:expect-not-assert id="preprint-ref-checks-xspec-assert" role="error"/>
       </x:scenario>
+      <x:scenario label="preprint-ref-volume-pass">
+        <x:context href="../tests/rp/preprint-ref-checks/preprint-ref-volume/pass.xml"/>
+        <x:expect-not-report id="preprint-ref-volume" role="error"/>
+        <x:expect-not-assert id="preprint-ref-checks-xspec-assert" role="error"/>
+      </x:scenario>
+      <x:scenario label="preprint-ref-volume-fail">
+        <x:context href="../tests/rp/preprint-ref-checks/preprint-ref-volume/fail.xml"/>
+        <x:expect-report id="preprint-ref-volume" role="error"/>
+        <x:expect-not-assert id="preprint-ref-checks-xspec-assert" role="error"/>
+      </x:scenario>
     </x:scenario>
     <x:scenario label="preprint-source-checks">
       <x:scenario label="preprint-source-pass">