From d9e81d10bb0457820a3fb964ad562cda2e087fd2 Mon Sep 17 00:00:00 2001 From: LinaKind Date: Wed, 8 Jan 2025 13:40:32 +0000 Subject: [PATCH] Rename a method for consistency with similar classes https://github.com/elifesciences/issues/issues/9034 --- src/Controller/ArticlesController.php | 2 +- src/ViewModel/Converter/AssessmentBuilder.php | 2 +- test/ViewModel/Converter/AssessmentBuilderTest.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Controller/ArticlesController.php b/src/Controller/ArticlesController.php index eedb96bf3..4c55dfbf7 100644 --- a/src/Controller/ArticlesController.php +++ b/src/Controller/ArticlesController.php @@ -650,7 +650,7 @@ private function createFirstPage(Request $request, string $id, array $arguments) null, null, null, - $assessmentBuilder->createAssessment($elifeAssessment) + $assessmentBuilder->build($elifeAssessment) ); } }); diff --git a/src/ViewModel/Converter/AssessmentBuilder.php b/src/ViewModel/Converter/AssessmentBuilder.php index 0e6bc236f..90c7d6fe5 100644 --- a/src/ViewModel/Converter/AssessmentBuilder.php +++ b/src/ViewModel/Converter/AssessmentBuilder.php @@ -24,7 +24,7 @@ class AssessmentBuilder 'inadequate' => 'Methods, data and analyses do not support the primary claims', ]; - final public function createAssessment(ArticleSection $elifeAssessment): Assessment { + final public function build(ArticleSection $elifeAssessment): Assessment { $summary = 'During the peer-review process the editor and reviewers write an eLife Assessment that summarises the significance of the findings reported in the article (on a scale ranging from landmark to useful) and the strength of the evidence (on a scale ranging from exceptional to inadequate). Learn more about eLife Assessments'; $significanceTerms = ['Landmark', 'Fundamental', 'Important', 'Valuable', 'Useful']; $strengthTerms = ['Exceptional', 'Compelling', 'Convincing', 'Solid', 'Incomplete', 'Inadequate']; diff --git a/test/ViewModel/Converter/AssessmentBuilderTest.php b/test/ViewModel/Converter/AssessmentBuilderTest.php index 08481525d..c23ae7215 100644 --- a/test/ViewModel/Converter/AssessmentBuilderTest.php +++ b/test/ViewModel/Converter/AssessmentBuilderTest.php @@ -174,7 +174,7 @@ private function getTestResult(string $contentText) $doi = '10.7554/eLife.94242.3.sa0'; $id = 'sa0'; $elifeAssessment = new ArticleSection($content, $doi, $id); - return $assessmentBuilder->createAssessment($elifeAssessment); + return $assessmentBuilder->build($elifeAssessment); } private function assertHasSignificance(string $term, Assessment $result)