From da5503f33f0ecad33a9e75068fe726f8a3b62ff7 Mon Sep 17 00:00:00 2001
From: LinaKind <l.kinduryte@elifesciences.org>
Date: Mon, 17 Feb 2025 14:59:44 +0000
Subject: [PATCH] Use the updated api-sdk version to allow querying of the API
 with elifeAssessmentSignificance terms

https://github.com/elifesciences/issues/issues/9169
---
 composer.lock                            | 12 ++++++------
 src/Controller/BrowseController.php      |  2 +-
 test/Controller/BrowseControllerTest.php |  2 ++
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/composer.lock b/composer.lock
index 988c8bb2..a1f436fd 100644
--- a/composer.lock
+++ b/composer.lock
@@ -1277,12 +1277,12 @@
             "source": {
                 "type": "git",
                 "url": "https://github.com/elifesciences/api-sdk-php.git",
-                "reference": "cb9bd20aa11387c27335c66ef937aae933b1f31c"
+                "reference": "258df21a415737214749ba5df7e4ec4999fd0631"
             },
             "dist": {
                 "type": "zip",
-                "url": "https://api.github.com/repos/elifesciences/api-sdk-php/zipball/cb9bd20aa11387c27335c66ef937aae933b1f31c",
-                "reference": "cb9bd20aa11387c27335c66ef937aae933b1f31c",
+                "url": "https://api.github.com/repos/elifesciences/api-sdk-php/zipball/258df21a415737214749ba5df7e4ec4999fd0631",
+                "reference": "258df21a415737214749ba5df7e4ec4999fd0631",
                 "shasum": ""
             },
             "require": {
@@ -1298,7 +1298,7 @@
             },
             "require-dev": {
                 "csa/guzzle-cache-middleware": "^1.0",
-                "elife/api": "2.30.0",
+                "elife/api": "2.31.3",
                 "elife/api-validator": "^1.0",
                 "guzzlehttp/guzzle": "^6.0",
                 "justinrainbow/json-schema": "^3.0 || ^4.0 || ^5.0",
@@ -1331,7 +1331,7 @@
                 "issues": "https://github.com/elifesciences/api-sdk-php/issues",
                 "source": "https://github.com/elifesciences/api-sdk-php/tree/master"
             },
-            "time": "2025-01-10T11:50:41+00:00"
+            "time": "2025-02-14T15:23:46+00:00"
         },
         {
             "name": "elife/civi-contacts",
@@ -6428,5 +6428,5 @@
     "platform-overrides": {
         "php": "7.1.33"
     },
-    "plugin-api-version": "2.6.0"
+    "plugin-api-version": "2.2.0"
 }
diff --git a/src/Controller/BrowseController.php b/src/Controller/BrowseController.php
index a7e93e7a..c0c49c9b 100644
--- a/src/Controller/BrowseController.php
+++ b/src/Controller/BrowseController.php
@@ -41,7 +41,7 @@ public function queryAction(Request $request) : Response
 
         $search = $this->get('elife.api_sdk.search.page')
             ->forSubject(...$arguments['query']['subjects'])
-            // ->forElifeAssessmentSignificance(...ElifeAssessmentTermsFilter::fromMinimumSignificance($arguments['query']['minimumSignificance']))
+            ->forElifeAssessmentSignificance(...ElifeAssessmentTermsFilter::fromMinimumSignificance($arguments['query']['minimumSignificance']))
             ->forType(...$apiTypes)
             ->sortBy('date');
 
diff --git a/test/Controller/BrowseControllerTest.php b/test/Controller/BrowseControllerTest.php
index 0f93fc9b..3bd96470 100644
--- a/test/Controller/BrowseControllerTest.php
+++ b/test/Controller/BrowseControllerTest.php
@@ -317,6 +317,7 @@ private function buildUrlRequestForOneItem()
             'per-page' => '1',
             'sort' => 'date',
             'order' => 'desc',
+            'elifeAssessmentSignificance[]' => ['important', 'fundamental', 'landmark', 'useful', 'valuable', 'not-assigned'],
             'type[]' => $this->researchTypes,
             'use-date' => 'default',
         ]);
@@ -330,6 +331,7 @@ private function buildUrlRequestForTenItems()
             'per-page' => '10',
             'sort' => 'date',
             'order' => 'desc',
+            'elifeAssessmentSignificance[]' => ['important', 'fundamental', 'landmark', 'useful', 'valuable', 'not-assigned'],
             'type[]' => $this->researchTypes,
             'use-date' => 'default',
         ]);