Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sink cloud versions of ipc #705

Closed
josevalim opened this issue Sep 9, 2023 · 7 comments · Fixed by #961
Closed

Use sink cloud versions of ipc #705

josevalim opened this issue Sep 9, 2023 · 7 comments · Fixed by #961

Comments

@josevalim
Copy link
Member

We need a new Explorer version:

@Qqwy
Copy link
Contributor

Qqwy commented Nov 18, 2023

@josevalim FYI I briefly spoke with Ritchie on the Polars Discord today and he merged the sink_ipc_cloud PR just now, so work on the Explorer side can now continue!

@philss
Copy link
Member

philss commented Nov 29, 2023

First of all: awesome work there on Polars, @Qqwy !! 🎉

Just to let you know that I'm working on this to bring the functionality to Explorer :)

@philss
Copy link
Member

philss commented Jan 19, 2024

Hey @Qqwy, I had some issues trying to make the Sink IPC work, so I opened an issue upstream: pola-rs/polars#13614

I tried to find a fix for it, but I couldn't understand where the "block_on" is happening (twice). Would you mind to take a look?

@Qqwy
Copy link
Contributor

Qqwy commented Jan 20, 2024

Hi there! Thanks for tagging me, I'll dig into this problem. block_on is probably called from within the #[tokio::main] decorators. The crash happens because for some reason an attempt is made to start an async Tokio runtime from within a pre-existing Tokio runtime. Why that happens is of course the thing to figure out as it shouldn't.

Just to double-check: Is this only a problem with sink_ipc_cloud and not with sink_parquet_cloud?

@josevalim
Copy link
Member Author

As far as I know, only ipc. @philss will be able to confirm though!

@philss
Copy link
Member

philss commented Jan 24, 2024

@Qqwy yeah, it's only with the sink_ipc_cloud. The sink_parquet_cloud is working good, and it's already in main.

PS: sorry, I didn't see the ping before 😬

@Qqwy
Copy link
Contributor

Qqwy commented Feb 4, 2024

@philss I have created a PR with a fix on the Polars repo: pola-rs/polars#14262

@josevalim josevalim changed the title Use sink cloud versions of parquet and ipc Use sink cloud versions of ipc Feb 20, 2024
philss added a commit that referenced this issue Aug 15, 2024
With this, we can enable the `to_parquet/2` again, and add the `to_ipc/2` cloud.

Closes #705
@philss philss closed this as completed in a4963f3 Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants