Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stronglyConnectedComponents description #23

Open
mcapodici opened this issue Dec 14, 2018 · 0 comments
Open

stronglyConnectedComponents description #23

mcapodici opened this issue Dec 14, 2018 · 0 comments

Comments

@mcapodici
Copy link

mcapodici commented Dec 14, 2018

The description of stronglyConnectedComponents is a bit confusing to me. Maybe it is confusing to others, so here is my suggestion.

You say in the description:

Ok acyclic means that the graph was acyclic (so every node in the graph forms a single connected component).

Would it be less ambiguous to say "Ok acyclic means that the graph was acyclic. Therefore every node in the graph forms it's own single connected component. Rather than return a list of components that are just individual nodes, this just returns the whole graph as an ACyclicGraph"

P.S. I'd kind of prefer this to always return List (Graph n e) - but that's just my taste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant