Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly compare bytes in == #1092

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

correctly compare bytes in == #1092

wants to merge 2 commits into from
+14 −0

Conversation

harrysarson
Copy link
Contributor

Bytes equality requires a special case in _Utils_eqHelp. This PR adds that special case.

Fixes elm/bytes#15

@harrysarson
Copy link
Contributor Author 

 ✖  fatal     HttpError: Resource not accessible by integration 
    at /node_modules/@octokit/request/lib/request.js:56:27
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async Object.doComment [as comment] (/entrypoint.js:47:5)

The GH action does not seem to work. Pinging @supermario :)

@harrysarson
Copy link
Contributor Author

harrysarson commented Aug 28, 2020 •
edited
Loading

CI does pass: https://travis-ci.org/github/elm/core/builds/721811877. Not sure why GH does not display it 🤷

lydell
lydell reviewed Aug 29, 2020
View reviewed changes
src/Elm/Kernel/Utils.js Outdated Show resolved Hide resolved
rupertlssmith pushed a commit to elm-janitor/core that referenced this pull request Feb 11, 2022
@harrysarson @rupertlssmith
fixes elm#1092
3be3731 
Correctly compare encoded bytes in `==`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lydell lydell lydell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comparing two Byte values always result in True, regardless of the actual bytes
2 participants
@harrysarson @lydell