Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url.Parser.string does not decode the value #16

Open
tomstejskal opened this issue Sep 28, 2018 · 1 comment
Open

Url.Parser.string does not decode the value #16

tomstejskal opened this issue Sep 28, 2018 · 1 comment
Labels
breaking would require a MAJOR release request

Comments

@tomstejskal
Copy link

The string combinator from Url.Parser does not decode the value using Url.percentDecode.
I think the implementation should be something like this:

string : Parser (String -> a) a
string =
    custom "STRING" Url.percentDecode
@AlienKevin
Copy link

Second that! This causes inconvenience when I have a path that contains spaces that are encoded as "%20" and never decoded back to " ".

@evancz evancz added breaking would require a MAJOR release request labels Feb 9, 2021
@evancz evancz mentioned this issue Feb 10, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking would require a MAJOR release request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomstejskal @evancz @AlienKevin