You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In light of the question of how URLs should be percent-encoded (#42), I think there is a more pressing underlying issue.
There is confusion about how Url.Builder and Url.Parser methods work, since the documentation on percentEncode makes it seem that functions like absolute, relative, and crossOrigin will also do percent-encoding on the paths, as evidenced by the top comment in #25.
To address the misunderstanding of what gets percent-encoded by those functions and how to achieve the desired behavior, we can change the documentation for percentEncode from
Use Url.Builder instead! Functions like absolute, relative, and crossOrigin already do this automatically! percentEncode is only available so that extremely custom cases are possible, if needed.
to something like
Use Url.Builder instead! Functions like absolute, relative, and crossOrigin already encode query parameters automatically! percentEncode is only available so that extremely custom cases are possible, if needed.
Note that these functions do not percent-encode path components, because not everyone needs the same encoding. If you need to do that, you need to call this function on each path, for example Url.Builder.absolute (List.map percentEncode ["encode me"]) [] to get /encode%20me.
Similarly, the documentation for percentDecode can be changed from
Use Url.Parser instead! It will decode query parameters appropriately already! percentDecode is only available so that extremely custom cases are possible, if needed.
to
Use Url.Parser instead! It will decode query parameters appropriately already! percentDecode is only available so that extremely custom cases are possible, if needed.
In light of the question of how URLs should be percent-encoded (#42), I think there is a more pressing underlying issue.
There is confusion about how
Url.Builder
andUrl.Parser
methods work, since the documentation onpercentEncode
makes it seem that functions likeabsolute
,relative
, andcrossOrigin
will also do percent-encoding on the paths, as evidenced by the top comment in #25.To address the misunderstanding of what gets percent-encoded by those functions and how to achieve the desired behavior, we can change the documentation for
percentEncode
fromto something like
Similarly, the documentation for
percentDecode
can be changed fromto
The text was updated successfully, but these errors were encountered: