Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Automatic Package Restore #373

Closed
atifaziz opened this issue Aug 25, 2015 · 9 comments
Closed

Migrate to Automatic Package Restore #373

atifaziz opened this issue Aug 25, 2015 · 9 comments

Comments

@atifaziz
Copy link
Member

https://code.google.com/r/jamesdriscoll71-nuget-changes

Purpose of code changes on this branch:

Change the way we do NuGet in line with:
http://blog.davidebbo.com/2014/01/the-right-way-to-restore-nuget-packages.html

When reviewing my code changes, please focus on:

After the review, I'll merge this branch into:
/trunk


Originally reported on Google Code with ID 373

Reported by @JamesDriscoll on 2014-10-12 09:59:35

@atifaziz
Copy link
Member Author

I've almost merged this. The only issue I'm seeing is that there is a discrepancy between building from VS and the command line. If you do a fresh clone of your repo, build from within VS and run the demo web site, then checking out the log page produces the following error:

Unable to load DLL 'SQLite.Interop.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E)

If you take another fresh clone (or clean the existing one with hg purge --all) and use build.cmd then the demo site works flawlessly. It seems as if the restore from within VS does not honour package restore for Web Site projects.

Could you take a look at this? Thanks!


Reported by @atifaziz on 2014-10-12 22:57:02

  • Status changed: Started
  • Labels added: Component-Scripts

@atifaziz
Copy link
Member Author

Reported by @atifaziz on 2014-10-12 22:57:26

  • Labels added: Milestone-Release2.0

@atifaziz
Copy link
Member Author

I also noticed that NuGet.exe was now being downloaded to tools when going over build.cmd but the added file is not being ignored (e.g. shows up in hg stat -S or when just doing hg stat in the tools directory). Perhaps .hgignore needs updating?

P.S. Don't forget to turn reviewing on on the clone repo.


Reported by @atifaziz on 2014-10-13 06:32:38

@atifaziz
Copy link
Member Author

Downloading NuGet.exe behind a proxy when building over build.cmd fails with:

C:\ELMAH\nuget\nugetRestore.proj(39,9): error : The remote server returned an error: (407) Proxy Authentication Required

Reported by @atifaziz on 2014-10-13 06:35:34

@atifaziz
Copy link
Member Author

For a potential fix to the above comment, see the following Web Essentials 2013 issue that's in the same vein: madskristensen/WebEssentials2013#1293


Reported by @atifaziz on 2014-10-13 06:46:11

@atifaziz
Copy link
Member Author

I've merged changes thus far (revision fbc19da53512).
Issue in comment 4th above was address by revision 2b868f3d8a7f.


Reported by @atifaziz on 2015-03-04 08:09:31

@atifaziz
Copy link
Member Author

Addressed 3rd comment:
https://bitbucket.org/project-elmah/tools/commits/a8485ee5f0050197e44960d525180afa71504cbd

This concludes the review.


Reported by @atifaziz on 2015-03-04 08:16:31

  • Status changed: Fixed

@atifaziz
Copy link
Member Author

Problem highlighted in comment 1 still continues to exist and has been migrated as issue #384.


Reported by @atifaziz on 2015-03-04 08:33:29

  • Status changed: Started

@atifaziz
Copy link
Member Author

Reported by @atifaziz on 2015-03-04 10:49:53

  • Status changed: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant