Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing dap-mode locals cap #667

Closed
odysseyalive opened this issue Sep 13, 2022 · 18 comments
Closed

changing dap-mode locals cap #667

odysseyalive opened this issue Sep 13, 2022 · 18 comments

Comments

@odysseyalive
Copy link

Sorry, for the newbie question. I didn't see an IRC channel for LSP or any reference to this setting in the documentation.

I'm using dap-mode with PHP and Xdebug. My xdebug.var_display_max_data option is set to "-1". I'm still getting a variable cap at around 120 in the locals reference.

Where do we set the display caps for the references in the Locals window for dap-mode? Is that cap coming from another emacs module?

@odysseyalive odysseyalive changed the title changing dap-mode locals cap at 120 changing dap-mode locals cap Sep 13, 2022
@yyoncho
Copy link
Member

yyoncho commented Sep 13, 2022

We have discord here: https://discord.com/invite/swuxy5AAgT

Can you check if dap-ui-variable-length works for you.

@odysseyalive
Copy link
Author

Thanks for reminding me about that. I did discover that I had already set it at 10000 my configuration. I can confirm that is what it currently is set at with describe-variable. It doesn't appear to have any effect.

Running the latest Ubuntu install of Emacs 27.1

@yyoncho
Copy link
Member

yyoncho commented Sep 13, 2022

Can you do: (setq dap-print-io t) and then go to the messages buffer and check if the server message has the data you want to see. If the server message is fine then can you show me the message itself and a screenshot of how it is displayed in the UI.

@odysseyalive
Copy link
Author

I wish I could, but the data is sensitive information.

My message buffer is getting cropped, too. I set the eval-expression-print-length to nil, but I'm only getting a portion of the readout.

Is there something specific you are looking for in the message buffer that I can look for?

@yyoncho
Copy link
Member

yyoncho commented Sep 13, 2022

My message buffer is getting cropped

You mean that the message does not have the whole data?

I want to find out who is cutting the data, the UI or the server.

Also you can still create a function foo with one param "bar" with long value and send me the data for that fuction (it won't have antyhing sensitive)

@yyoncho
Copy link
Member

yyoncho commented Sep 13, 2022

There is message-log-max.

@odysseyalive
Copy link
Author

Here's a code snippet:

Same Code Snippet

It shows all 251 items in the locals reference:

Locals reference correct variable size

Interesting though, it cuts off after 100 records:

only 100 items showing

Thanks, in advance for your help in probing this issue!

@yyoncho
Copy link
Member

yyoncho commented Sep 13, 2022

Ok, I found the issue. I will try to provide a fix tomorrow my time.

@yyoncho
Copy link
Member

yyoncho commented Sep 15, 2022

Now you can use something like (setq dap-ui-default-fetch-count 100). FWIW the real solution is to create paging here.

@yyoncho
Copy link
Member

yyoncho commented Sep 15, 2022

JFYI don't upgrade treemacs when upgrading dap-mode because latest version of lsp-mode won't work with latest treemacs

@odysseyalive
Copy link
Author

JFYI don't upgrade treemacs when upgrading dap-mode because latest version of lsp-mode won't work with latest treemacs

Which version does it work with, so I know what to roll back to?

@yyoncho
Copy link
Member

yyoncho commented Sep 15, 2022

@bridgesense Alexander-Miller/treemacs#677 (comment)

@odysseyalive
Copy link
Author

odysseyalive commented Sep 15, 2022

Sorry to be a bother. When using the use-package command with lsp-mode, do the requirements override quelpa statements in the emacs config?

I uninstalled treemacs completely with the package manager and package-autoremove.

I placed this in my emacs config, prior to lsp stuff:

;; treemacs compatiblity fix
(use-package treemacs
     :quelpa t
     (treemacs
       :fetcher github
       :repo "alexander-miller/treemacs"
       :commit "938c2678dc29817f57871445bc25699da0df076d"))

But latest treemacs files still keep getting pulled?

@yyoncho
Copy link
Member

yyoncho commented Sep 15, 2022

I am not use-package expert, but putting something like this just before the use-package declaration should work:

(unless (featurep 'treemacs)
  (quelpa
   :fetcher 'github
   :repo "alexander-miller/treemacs"
   :commit "938c2678dc29817f57871445bc25699da0df076d"))

@yyoncho
Copy link
Member

yyoncho commented Sep 15, 2022

Also make sure that it runs before any package that requires treemacs otherwise it will install the master version again.

@odysseyalive
Copy link
Author

odysseyalive commented Sep 15, 2022

Yeah, I tried compiling that version of treemacs and swapping out the files and lsp-treemacs wouldn't run. Perhaps I need an older package of that, too?

dap-mode pretty much runs out of the box for a clean emacs install. This last commit breaks it. I'm sure there is a way to get this to work, but until there is some documentation to support installation workarounds -- I'd roll this back.

EDIT: I tried rolling dap-mode back to yesterday's commit. The local variables don't even show up. I wish I had backed things up!

:(

@odysseyalive
Copy link
Author

After tearing out and reinstalling everything, it's just the local variables that no longer show up. This may be an unrelated issue to another update that happened, because even when I roll back -- it's the local variables that are missing.

@odysseyalive
Copy link
Author

odysseyalive commented Sep 16, 2022

Is this what you were talking about, as far as the Treemacs issue?

missing local variables

I rolled EVERYTHING back to a couple of months ago. I compiled all the LSP modules from at least two months ago. I compiled an earlier version of treemacs.

I just updated all the packages in emacs a couple days ago, and didn't have any issues. Now all the local variables are missing. It doesn't appear to be a LSP issue, either?

In any case, I thought I could get some context in the issue you were having in treemacs?

Before, when the local variables would be missing, I'd just step forward a couple of times and they would come in. Now they don't come in at all. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants