Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ember-template-imports with content-tag #149

Closed
1 task
gitKrystan opened this issue Oct 19, 2023 · 0 comments · Fixed by #153
Closed
1 task

Replace ember-template-imports with content-tag #149

gitKrystan opened this issue Oct 19, 2023 · 0 comments · Fixed by #153
Labels
breaking Breaking changes

Comments

@gitKrystan
Copy link
Collaborator

gitKrystan commented Oct 19, 2023

Resources

https://github.com/embroider-build/content-tag
https://github.com/ember-template-imports/ember-template-imports/releases/tag/v4.0.0

Needs investigation

  • We might not be able to maintain compatibility with ember-template-imports preprocessed code, which would mean we'd have to drop support for it altogether.

    This would cause compatibility issues with eslint-plugin-ember until they are using content-tag. Additionally, if they start using content-tag, running prettier via eslint-plugin-ember won't be possible until this library supports content-tag. (Use custom parser for gts/gjs ember-cli/eslint-plugin-ember#1942 will resolve this risk and make compat with ember-template-imports unnecessary.)

I've started a PR here (#153) with the processor switched, but all the tests are failing. Contributions welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant