-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Classic Handlebars #14
Comments
I'm looking to use this for .mustache templates and I can see a few issues, but I'm not sure which would also be issues in other variants too and so maybe deserve their own issue, versus just being mentioned here:
I guess a more general question is how this interacts with .css, .js and .html tree-sitter parsers, if I use :TSPlaygroundToggle then text attributes in plain HTML sections seem to get detected as |
From reading tree-sitter/tree-sitter-html#5 it sounds like the more basic, non-glimmer/ember usages might be easier done by a seperate treesitter plugin following the erb example. I might give that a go. |
Reading your test cases, the multiline comment appears to be an intentional thing, requiring the |
|
@bnomei would you be interested in submitting a PR? |
Glimmer and Handlebars have diverged syntactically in many ways; not only does Glimmer define plenty of things beyond Handlebars, Handlebars has some syntax that is not part of Glimmer.
It might be worth supporting those elements, even though they're not part of Glimmer specifically, in order to handle a few cases that are not currently handled.
Partial injection
The
>
after the{{
indicated a partial will be injected in this location. Support would just require handling the>
and highlighting the expression as amustache_statement
The text was updated successfully, but these errors were encountered: