Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC.Record.refresh does not work #11

Open
blt04 opened this issue Oct 4, 2011 · 0 comments
Open

SC.Record.refresh does not work #11

blt04 opened this issue Oct 4, 2011 · 0 comments

Comments

@blt04
Copy link

blt04 commented Oct 4, 2011

Calling refresh on a SC.Record object does not actually refresh the record.

This has to do with line 290 of lib/system/record.js. If refresh is called with no arguments or with recordOnly = false, the statement:

if (recordOnly || (none(recordOnly) && none(prKey)))

will always evaluate to false.

none(recordOnly) should be removed.
blt04 added a commit to blt04/sproutcore-datastore that referenced this issue Oct 21, 2011
@blt04
Fix typos in SC.Record
41ce89f 
* Always use a storeKey when calling parentStoreKeyExists
* Fix refresh, commitRecord and destroy to work when recordOnly is false

Refs emberjs-addons#11.
@blt04 blt04 mentioned this issue Oct 21, 2011
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blt04