Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish porting tests from QUnit to jest #206

Open
ef4 opened this issue Jun 3, 2019 · 3 comments
Open

Finish porting tests from QUnit to jest #206

ef4 opened this issue Jun 3, 2019 · 3 comments
Labels

Comments

@ef4
Copy link
Contributor

ef4 commented Jun 3, 2019

We have some tests in QUnit and some in jest. When the whole suite runs, jest invokes QUnit. It would be better to factor out the remaining use of QUnit and have one thing.

cc @Turbo87

@stefanpenner
Copy link
Collaborator

@ef4 how are you enjoying jest?

@ef4
Copy link
Contributor Author

ef4 commented Jun 3, 2019

It's fine. Mostly it was a good choice here because it replaced a perl & bash based parallel runner for our various test suites. I don't think it's necessarily better than QUnit at the level of authoring individual tests.

@stefanpenner: related to test ergonomics, I think I'm still seeing babel/broccoli-babel-transpiler#169 in the embroider test suite. It manifests as a timeout when the jest-invoked QUnit process fails to exit, even though QUnit got to the end of its suite.

@stefanpenner
Copy link
Collaborator

@ef4 oh, I forgot about that. Does it reproduce consistently for you?

I'll add this to my todo list, please feel free to remind me if it isn't addressed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants