[[email protected]]: The hbs plugin doesn't forward the options parameter to this.resolve

[abeforgit]

I (have to) use the commonjs rollup plugin for my addon, and I'm getting the following warning in my build output:

[plugin commonjs--resolver] It appears a plugin has implemented a "resolveId" hook that uses "this.resolve" without forwarding the third "options" parameter of "resolveId". This is problematic as it can lead to wrong module resolutions especially for the node-resolve plugin and in certain cases cause early exit errors for the commonjs plugin.
In rare cases, this warning can appear if the same file is both imported and required from the same mixed ES/CommonJS module, in which case it can be ignored.

Looking at https://github.com/embroider-build/embroider/blob/main/packages/addon-dev/src/rollup-hbs-plugin.ts that seems to be the case indeed.
It doesn't seem to be causing any issues for me, but it seems like a very easy fix. I'll make a pr for it as well.

some reference info from rollup's maintainer: lightyen/typescript-paths#3 (comment)