Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMF: "ship_date" in soft_sediment is a string and not a date #34

Open
cymon opened this issue Nov 6, 2024 · 2 comments
Open

UMF: "ship_date" in soft_sediment is a string and not a date #34

cymon opened this issue Nov 6, 2024 · 2 comments
Assignees

Comments

@cymon
Copy link

cymon commented Nov 6, 2024

Processing observatory_id='UMF' - sampling_strategy='soft_sediment' - sheet_type='sampling'
Sample sheet link:

ValidationError: 1 validation error for Model
ship_date
Value error, Unrecognised value: to_arrive_Sep_2023 [type=value_error, input_value='to_arrive_Sep_2023', input_type=str]
For further information visit https://errors.pydantic.dev/2.8/v/value_error

"to_arrive_Sep_2023" is not a valid ISO 8601 date

@kmexter
Copy link
Contributor

kmexter commented Nov 7, 2024

also ok - these are comments, these are not values that get into the transformed data and triple store

@isanti
Copy link

isanti commented Jan 28, 2025

This and similar issues with people (inc. me) adding notes are fixed when samples are shipped for sequencing, and I go over the list of metadata.
This should not be a problem for QC as the QC will come after sample shipment.

Now, FYI, I still wait for UMF samples but we are in contact for checking everything.

I keep this open to check again in ~a month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants