Browser shortcut keys don't work with an SDL2 Emscripten page that handles keypress events

[adam4235]

I reported this issue here a while ago:

emscripten-ports/SDL2#128

That repository got archived but the issue still remains (Emscripten 3.1.7).

To summarize, I want my application to handle some keypresses, but I want the other keypresses that I don't handle to fall back on the regular browser behaviour (such as F11 making the window full screen, for Firefox).

There was a patch that fixed it which @Daft-Freak said he would need to test before applying.

I also noticed that the issue did not seem to be present in an older version of Emscripten, 1.39.8 (i.e. without the patch, the behaviour I wanted was already happening, as long as I created the FilterEvents function mentioned in that issue). I can't downgrade to work around it because that version has other issues, but it might be interesting that something other than that patch caused this behaviour to change.

[Daft-Freak]

Ah, I got as far as committing emscripten-ports/SDL2@65c1316, but apparently never merged it.

The only side-effect I can see there is not preventDefault-ing keys that SDL doesn't handle... which probably isn't a bad thing. May just rebase and push upstream when I get the chance.

[Daft-Freak]

Did a quick check that SDL_EventState still worked and... pushed: libsdl-org/SDL@9de97e1

[adam4235]

Thanks!

[sbc100]

Presumably we still to update the SDL version used in emscripten?

[adam4235]

OK sorry I'm not sure of the process - maybe I wasn't supposed to close this? Is there anything else I need to do?

[Daft-Freak]

Hmm, yeah need to update the tag here. Not sure what we're doing for updates outside of upstream releases now though...

[kripken]

I believe we can update the "tag" in ports/sdl2.py to any hash of a commit in that repo. That is, the https://github.com/libsdl-org/SDL/archive/???.zip notation works with both tag names and hashes. So if we want a commit before there is a tag that is possible.

[jdarpinian]

This fix was undone shortly after it was committed, by this commit libsdl-org/SDL@9221548

[Daft-Freak]

Hmm, not sure if that was intentional... or when I might get the chance to see if adding the prevent_default = SDL_SendKeyboardKey... back breaks anything.