Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded values in 3 descriptors without support for new materials #5

Open
ammar257ammar opened this issue Jul 25, 2020 · 3 comments

Comments

@ammar257ammar
Copy link

Dear Egon,

I am trying to apply NanoJava descriptor calculation on Gold oxide and Silver oxide nano particles. I made a CML XML file containing both of them (please see the attachment)

There are 11 descriptors in NanoJava, 3 of them contains hard coded values for metal oxide descriptors which don't include Au/Ag so these descriptors can not be generated for our nanoparticles, and there descriptors are:

1- EnergyBandDescriptor: no support for Au and Ag
2- HeatOfFormation: no support for Au and Ag
3- HeatOfFormationMopac2012: no support for Au and Ag

oxides.zip

Thank you

@egonw
Copy link
Contributor

egonw commented Jul 26, 2020

The values for EnergyBandDescriptor come from the article, IIRC, while for the other two I have taken them from the article but also recalculated and added values for metal oxides not in the article. I guess we have to calculate them for your two.

@ammar257ammar
Copy link
Author

Can you please send me the related article to see how the descriptor is calculated and do it for my compounds?

@egonw
Copy link
Contributor

egonw commented Aug 3, 2020

Now, these things should actually be provided by the ontology annotation and Blue Obelisk descriptor ontology, see https://link.springer.com/article/10.1186/1758-2946-3-37 But then the JavaDoc should also actually give the ontology annotation, which it currently does not seem to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants