Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data type restrictions are ignoed #57

Open
DerAndereAndi opened this issue Feb 17, 2025 · 0 comments
Open

Data type restrictions are ignoed #57

DerAndereAndi opened this issue Feb 17, 2025 · 0 comments
Labels
wontfix This will not be worked on

Comments

@DerAndereAndi
Copy link
Member

Some data models are re-used inside data structures with restrictions applied. E.g. EntityAddressType is used within NodeManagementDetailedDiscoveryEntityInformationType but only allowing the field entity. In this case the device field will also sent if set, which is the normal case.

Right now the implementation ignores all these all allows and serializes all fields. It has no functional impact, as the other unknown or not-defined fields should be ignored by the receiver anyway. And because all fields are structurally always optionals, and therefor new fields can be added in future version of SPINE without breaking compatibility, this won't be a real problem. Even though formally this is incorrect and a certification would most likely fail because of this.

@DerAndereAndi DerAndereAndi added the wontfix This will not be worked on label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant