Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze channels function is ugly #7

Open
endolith opened this issue Mar 24, 2016 · 1 comment
Open

Analyze channels function is ugly #7

endolith opened this issue Mar 24, 2016 · 1 comment

Comments

@endolith
Copy link
Owner

I've got common.py with load() and analyze_channels(), but then wave_analyzer.analyze() does the same thing.

I want everything wrapped in try: so it can run without any command line window and just pop up the results using easygui, or Exceptions in easygui if they happen, but then everything is wrapped in a try statement which is ugly. Separate file that launches the rest?

Having each analysis in its own function is nice, but if multiple functions are doing the same FFT on the same signal, wouldn't it be better to keep the previously-computed FFT to save time? So I should pass an object to the analysis functions instead, and if they compute FFT they should attach FFT results to the object as a cache?

Then I've still got the standalone gists for each analysis function that should be merged into this and killed off.

Suggestions welcome

@endolith
Copy link
Owner Author

endolith commented Jul 8, 2017

I reorganized it into an importable package, so this is partially fixed. Still some loose ends to tie up, though.

@endolith endolith changed the title This is ugly Analyze channels function is ugly Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant