Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Error on retrieving server data from provider"? #14

Closed
someonedeepintheinternet opened this issue Aug 24, 2023 · 4 comments
Closed

"Error on retrieving server data from provider"? #14

someonedeepintheinternet opened this issue Aug 24, 2023 · 4 comments

Comments

@someonedeepintheinternet

Hi, I found this nice mod and downloaded it but when I joined my world, I immediately received this message in the chat which concerns me on upcoming crashings:

Error on retrieving server data from provider
mcp.mobius.waila.plugin.textile.provider.FluidStorageProvider$$Lambda$15031/0x0000000801cf8000

@enjarai
Copy link
Owner

enjarai commented Aug 24, 2023

I can try to find the cause if you send a full log that includes this error. It's probably harmless though, so I wouldn't worry about it.

@deirn
Copy link

deirn commented Aug 27, 2023

The issue is on here

public @Nullable Storage<FluidVariant> getFluidStorage(Direction side) {
if (side.getAxis().isHorizontal()) {
return fluidStorage;
}
return null;
}

On 1.20, FAPI's ItemStorage.SIDED and FluidStorage.SIDED allows for null side. The method on SidedStorageBlockEntity is not marked as such though (it's an oversight).

FabricMC/fabric#3281
badasintended/wthit#231

@enjarai
Copy link
Owner

enjarai commented Aug 27, 2023

Oh I see, thanks for letting me know! I'll push an update to implement a null check.

@someonedeepintheinternet
Copy link
Author

oh well, guess I don't have to explain further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants