pure usage swallows my ability to send SIGINT

[cdaringe]

problem

i am unable to ctrl+c exit my program once i have run this pkg

solution

commenting out my usage of this pkg restores default node behavior

[doowb]

@cdaringe can you provide an example that reproduces this issue? Also, which version of node and OS are you using?

[cdaringe]

Hi @doowb, give me a couple hours, I'm at the dr! Thx for following up

[cdaringe]

https://github.com/cdaringe/prompt-no-exit

[cdaringe]

Also, which version of node and OS are you using?

[email protected]
osx@high-sierra

[jonschlinkert]

Is this what you mean by "pure usage"? On that line, you're creating a prompt and keeping it open (with module.exports.run()).

When a new prompt is created, it instantiates readline UI which starts listening for SIGINT.

[cdaringe]

I meant using this PKG directly vs enquirer. If you run the example you can see that even after responses are collected (prompt run() resolves and I have user input), you can't sigint the process. I keep the process up artificially with a time out such that a tester can easily verify this. By the time execution has reached that point, I should be able to sigint out out of node. Instead, however, the signal is swallowed as a side effect of running the prompt. I would think such a side effect would be removed by the time the promise resovles and user input is captured

[jonschlinkert]

I would think such a side effect would be removed by the time the promise resovles and user input is captured

You'll need to close the session. This is something that enquirer does after prompts are run, but in order to allow prompts to be chained or nested, we don't close the session in individual prompts. I'm open to alternatives if you have suggestions or want to do a pull request.

I believe prompt.ui.close() would do the trick, but that's from memory. If that doesn't work we can look into it further.

[doowb]

I believe prompt.ui.close()

This works. I was just testing that out and about to say the same thing.

[cdaringe]

cool, ya, prompt.ui.close() was what i was looking for. thx!

I'm open to alternatives if you have suggestions or want to do a pull request

i'm still digesting this. part of me feels that when the prompt has finished... it really should be finished unless explicitly told to do so otherwise. sounds like prompt-* modules were really designed for enquirer interop though, and took defaults that worked for that module's context.

we should probably document ui.close in the README at the least, as project header states it can be used standalone. i did not expect it to effect my environment after i finished getting user input.

[romainseb]

I searched for hours to figured out where my process was stucked ( i thought it was caused by other third-part libs )
Some addition in the README might be a cool idea :)