Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remaining protocol logic stuff from server to protocol crate #486

Closed
ameba23 opened this issue Nov 9, 2023 · 1 comment
Closed
Assignees
Labels

Comments

@ameba23
Copy link
Contributor

ameba23 commented Nov 9, 2023

Recently the transport and protocol execution logic for the signing and DKG protocols moved out of server and into a new crate entropy-protocol which is designed to be run both on the server and client side.

Because of fears about the difficulties with wasm, i moved only the bare minimum things needed on the client side. There are still modules in server which relate to protocol execution or transport but aren't needed on the client side.

Why is this issue relevant?

I think it makes sense to keep that stuff all together in one crate

What steps are required to resolve this?

I would move these modules into entropy-protocol but gate them behind the server feature flag so they are only compiled in 'server mode'.

Does this change the spec? HTTP, extrinsic, or storage? Is it breaking? Clearly describe the new interface.

No this should not break anything

@ameba23 ameba23 self-assigned this Nov 9, 2023
@ameba23 ameba23 added this to the Core v0.1.0 - Devnet 🚀 milestone Nov 9, 2023
@JesseAbram JesseAbram removed this from the Core v0.1.0 - Devnet 🚀 milestone Mar 12, 2024
@ameba23
Copy link
Contributor Author

ameba23 commented Jul 30, 2024

Closing as no longer relevant following removal of private mode.

@ameba23 ameba23 closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants