Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove entropy-protocol crate and move sign_and_encrypt module to entropy-client #813

Open
ameba23 opened this issue May 6, 2024 · 1 comment
Labels

Comments

@ameba23
Copy link
Contributor

ameba23 commented May 6, 2024

Since we are removing private mode i think we no longer need the entropy-protocol crate.

Anything in it which is needed by both a client and entropy-tss (eg: the hpke encryption stuff) should be moved to entropy-client, and anything which is only used by entropy-tss (eg: the protocol execution loop and Listener) should be moved to entropy-tss.

@HCastano HCastano changed the title Refactor - Remove entropy-protocol crate and move sign_and_encrypt module to entropy-client. Remove entropy-protocol crate and move sign_and_encrypt module to entropy-client May 17, 2024
@HCastano HCastano moved this to 📋 Backlog in Entropy Core May 17, 2024
@ameba23
Copy link
Contributor Author

ameba23 commented Jul 30, 2024

Things which would move to entropy-client:

  • RecoverableSignature
  • KeyParams
  • sign_and_encrypt - as well as the nodejs tests for it.

Everything else would move to entropy-tss::signing_client (which should really be renamed protocol_client).

The tricky bit will be the integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants