Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to track subdirectories create/delete/rename event for file-provider #5150

Open
shawnh2 opened this issue Jan 25, 2025 · 0 comments
Labels
area/provider area/standalone Issues related to the standalone mode help wanted Extra attention is needed

Comments

@shawnh2
Copy link
Contributor

shawnh2 commented Jan 25, 2025

  • we should be handling the various change events in this region of code:

    switch event.Op {
    case fsnotify.Create, fsnotify.Write, fsnotify.Remove:
    // Since we do not watch any events in the subdirectories, any events involving files
    // modifications in current directory will trigger the event handling.
    goto handle
    default:
    // do nothing
    continue
    }

  • we should add tests for cases where the user creates, deletes, or renames a complete directory in one of the watched directories

Originally posted by @EshaanAgg in #5126 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider area/standalone Issues related to the standalone mode help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant