Unit tests: rpcdaemon test TraceCallExecutor::trace_filter crashes

[elmato]

Changes we made in the rawdb::read_body function introduced in this commit makes unit test "TraceCallExecutor::trace_filter" to crash.

The code was expecting blocks to have two transactions, one system tx at the beginning and one at the end of the block. We don't have that in our node implementation.

./rpcdaemon_test "TraceCallExecutor::trace_filter"
Filters: TraceCallExecutor::trace_filter
unknown file: Failure

Unexpected mock function call - returning default value.
    Function call: walk(@0x7f9040001de0 "BlockTransaction", { '\0', '\0', '\0', '\0', '\x5' (5), '\xC6' (198), '.' (46, 0x2E), 'i' (105, 0x69) }, 0, 32-byte object <50-1E 00-40 90-7F 00-00 00-00 00-00 00-00 00-00 00-25 F4-5B B3-55 00-00 50-29 F5-5B B3-55 00-00>)
          Returns: 8-byte object <00-00 00-00 00-00 00-00>
Google Mock tried the following 2 expectations, but none matched:

/home/matu/dev/new-silkworm-to-update/silkworm/silkrpc/core/evm_trace_test.cpp:3832: tried expectation #0: EXPECT_CALL(db_reader, walk(db::table::kBlockTransactionsName, silkworm::ByteView{kBlockTransactionKey1}, kBlockTransactionFixedBits1, _))...
  Expected arg #1: is equal to { '\0', '\0', '\0', '\0', '\x5' (5), '\xC6' (198), '.' (46, 0x2E), 'g' (103, 0x67) }
           Actual: { '\0', '\0', '\0', '\0', '\x5' (5), '\xC6' (198), '.' (46, 0x2E), 'i' (105, 0x69) }
         Expected: to be called once
           Actual: never called - unsatisfied and active
/home/matu/dev/new-silkworm-to-update/silkworm/silkrpc/core/evm_trace_test.cpp:3840: tried expectation #1: EXPECT_CALL(db_reader, walk(db::table::kBlockTransactionsName, silkworm::ByteView{kBlockTransactionKey2}, kBlockTransactionFixedBits2, _))...
  Expected arg #1: is equal to { '\0', '\0', '\0', '\0', '\x5' (5), '\xC6' (198), '.' (46, 0x2E), 'j' (106, 0x6A) }
           Actual: { '\0', '\0', '\0', '\0', '\x5' (5), '\xC6' (198), '.' (46, 0x2E), 'i' (105, 0x69) }
         Expected: to be called once
           Actual: never called - unsatisfied and active

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
rpcdaemon_test is a Catch v2.13.9 host application.
Run with -? for options

-------------------------------------------------------------------------------
TraceCallExecutor::trace_filter
  from block number < to block number
-------------------------------------------------------------------------------
/home/matu/dev/new-silkworm-to-update/silkworm/silkrpc/core/evm_trace_test.cpp:5247
...............................................................................

/home/matu/dev/new-silkworm-to-update/silkworm/silkrpc/core/evm_trace_test.cpp:5247: FAILED:
due to a fatal error condition:
  SIGSEGV - Segmentation violation signal

===============================================================================
test cases: 1 | 1 failed
assertions: 1 | 1 failed

[1]    488322 segmentation fault (core dumped)  ./rpcdaemon_test "TraceCallExecutor::trace_filter"

[stephenpdeos]

Related to #50

[arhag]

This should be fixed for EOS EVM Node and can be integrated into its main branch.

[stephenpdeos]

To close this out, we will update the master branch of Silkworm from upstream and then integrate into the main branches of our three dependent products.

[elmato]

This issue was solved by PR #108