Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrfioc2 software version and git tag #145

Closed
Insomnia1437 opened this issue Apr 10, 2024 · 2 comments · Fixed by #146
Closed

mrfioc2 software version and git tag #145

Insomnia1437 opened this issue Apr 10, 2024 · 2 comments · Fixed by #146
Assignees

Comments

@Insomnia1437
Copy link
Contributor

Insomnia1437 commented Apr 10, 2024

When I read $(P)SwVer-I PV, I found the value becomes something like: kmod-deb-3-0-2-gd1f0ec7f-dirty rather than 2.6.0

The MRF_VERSION macro is generated from genVersionHeader.pl

perl -CSD ../genVersionHeader.pl -t "../../.." -V "2.6.0" -N MRF_VERSION version.h
Creating VCS version header version.h with "kmod-deb-3-0-13-gd1f0ec7f-dirty"

inside genVersionHeader.pl, it uses the most recent tag and current commit ID to denote the mrfioc2 version

if(!$foundvcs && -d "$opt_t/.git") {
# same format as Mercurial
$result = `git --git-dir="$opt_t/.git" describe --tags --dirty`;
chomp($result);
if(!$? && length($result)>1) {
$opt_V = $result;
$foundvcs = 1;
}
}

Perhaps we should remove these two tags or modify genVersionHeader.pl to keep digit tags only

@jerzyjamroz
Copy link
Contributor

@Insomnia1437 , kmod releases are not the IOC releases. There is the IOC artefact so the ci is for the upgrade in the future.

@Insomnia1437
Copy link
Contributor Author

fix in #146
close this issue

@jerzyjamroz jerzyjamroz linked a pull request Apr 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants