Add source field into ParameterConfig to indicate data source #10105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjules
force-pushed
the
dont_sample_dm
branch
from
e4fe5fe to
cc42aac
Compare
CodSpeed Performance ReportMerging #10105 will not alter performanceComparing Summary
|
oyvindeide
reviewed
Feb 19, 2025
src/ert/enkf_main.py
Outdated
| @@ -198,8 +198,11 @@ def sample_prior( | |||
| parameters = list(parameter_configs.keys()) | |||
| for parameter in parameters: | |||
| config_node = parameter_configs[parameter] | |||
| if config_node.forward_init: | |||
| if config_node.forward_init or ( | |||
| type(config_node) == GenKwConfig and config_node.design | |||
There was a problem hiding this comment.
Think this logic would be simpler if we used something like source instead, also for the future, something like:
ParameterSource(StrEnum):
forward_init = auto()
sampled = auto()
design_matrix = auto()There was a problem hiding this comment.
Good! Will change correspondingly.
oyvindeide
reviewed
Feb 19, 2025
| @@ -46,11 +47,17 @@ def parse_config( | |||
| return args, kwargs | |||
|
|
|||
|
|
|||
| class ParameterSource(StrEnum): | |||
| forward_init = auto() | |||
There was a problem hiding this comment.
This should be changed to: user_provided, and we need to keep forward_init as is
xjules
changed the title
|
On hold .... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design matrix genkw looks to be sampled, which is not an issue as it gets overwritten right after sampling with the DM values.
This should prevent DM to be sampled.
Can be discussed if it is necessary.
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable