Identity for oauth aux #1286
Merged
Identity for oauth aux #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Richard87
requested changes
Feb 18, 2025
pkg/apis/radix/v1/radixapptypes.go
Outdated
|
|
||
| // UseAzureIdentity defines that credentials for authenticating using Azure Workload Identity instead of using a ClientSecret. | ||
| // +optional | ||
| UseAzureIdentity *bool `json:"useAzureIdentity,omitempty"` |
There was a problem hiding this comment.
To make it slighly more future proof, could we use something like
Credentials: "secret"|"AzureWorkloadIdentity"instead? (in case oauth2proxy changes their implementation and supports more providers that we want to support)
Moving to oauth2proxy requires moving other code due to cyclic references and several private methods. I think this need to be done without reviewving new functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.