Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed first letter of the Credentials enum #1294

Merged
merged 1 commit into from
Feb 20, 2025
+21 −21
Merged

Changed first letter of the Credentials enum #1294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/radix-operator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: radix-operator
version: 1.52.0
appVersion: 1.72.0
version: 1.52.1
appVersion: 1.72.1
kubeVersion: ">=1.24.0"
description: Radix Operator
keywords:
Expand Down
12 changes: 6 additions & 6 deletions charts/radix-operator/templates/radixapplication.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,13 +179,13 @@ spec:
type: boolean
type: object
credentials:
default: secret
default: Secret
description: Credentials defines credentials type for
authenticating. Default is a Secret, which represents
a client secret.
enum:
- secret
- azureWorkloadIdentity
- Secret
- AzureWorkloadIdentity
type: string
loginUrl:
description: |-
Expand Down Expand Up @@ -345,13 +345,13 @@ spec:
type: boolean
type: object
credentials:
default: secret
default: Secret
description: Credentials defines credentials type
for authenticating. Default is a Secret, which
represents a client secret.
enum:
- secret
- azureWorkloadIdentity
- Secret
- AzureWorkloadIdentity
type: string
loginUrl:
description: |-
Expand Down
6 changes: 3 additions & 3 deletions charts/radix-operator/templates/radixdeployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,13 @@ spec:
type: boolean
type: object
credentials:
default: secret
default: Secret
description: Credentials defines credentials type for
authenticating. Default is a Secret, which represents
a client secret.
enum:
- secret
- azureWorkloadIdentity
- Secret
- AzureWorkloadIdentity
type: string
loginUrl:
description: |-
Expand Down
12 changes: 6 additions & 6 deletions json-schema/radixapplication.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,11 @@
"type": "object"
},
"credentials": {
"default": "secret",
"default": "Secret",
"description": "Credentials defines credentials type for authenticating. Default is a Secret, which represents a client secret.",
"enum": [
"secret",
"azureWorkloadIdentity"
"Secret",
"AzureWorkloadIdentity"
],
"type": "string"
},
Expand Down Expand Up @@ -321,11 +321,11 @@
"type": "object"
},
"credentials": {
"default": "secret",
"default": "Secret",
"description": "Credentials defines credentials type for authenticating. Default is a Secret, which represents a client secret.",
"enum": [
"secret",
"azureWorkloadIdentity"
"Secret",
"AzureWorkloadIdentity"
],
"type": "string"
},
Expand Down
8 changes: 4 additions & 4 deletions pkg/apis/radix/v1/radixapptypes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,9 +922,9 @@ type CredentialsType string

const (
// Secret defines the client secret as a type of credentials
Secret CredentialsType = "secret"
Secret CredentialsType = "Secret"
// AzureWorkloadIdentity defines the Azure workload identity as a type of credentials
AzureWorkloadIdentity CredentialsType = "azureWorkloadIdentity"
AzureWorkloadIdentity CredentialsType = "AzureWorkloadIdentity"
)

// RadixVolumeMount defines an external storage resource.
Expand Down Expand Up @@ -1390,8 +1390,8 @@ type OAuth2 struct {
RedisStore *OAuth2RedisStore `json:"redisStore,omitempty"`

// Credentials defines credentials type for authenticating. Default is a Secret, which represents a client secret.
// +kubebuilder:validation:Enum=secret;azureWorkloadIdentity
// +kubebuilder:default:=secret
// +kubebuilder:validation:Enum=Secret;AzureWorkloadIdentity
// +kubebuilder:default:=Secret
// +optional
Credentials CredentialsType `json:"credentials,omitempty"`
}
Expand Down
Loading