Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shell): add finish time for stop service pod #4045

Merged

Conversation

ruoqianfengshao
Copy link
Contributor

@ruoqianfengshao ruoqianfengshao commented Jun 12, 2024

What this PR does / why we need it:

Add finish time for stop pod

I have checked the following points:

  • [ x ] I18n is finished and updated by cli
  • [ x ] Form fields validation is added and length is limited
  • [ x ] Display normally on small screen
  • [ x ] Display normally when some data is empty or null
  • [ x ] Display normally in english mode

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)

image

ChangeLog

Language Changelog
🇺🇸 English new feature, no break change
🇨🇳 中文 完全兼容

Need cherry-pick to release versions?

❎ No

@erda-bot erda-bot added the bugfix Used in pr label Jun 12, 2024
@ruoqianfengshao ruoqianfengshao force-pushed the feature/add-pod-finish-time branch from 528300c to 85e7b45 Compare June 12, 2024 10:51
@laojun laojun merged commit 53127c5 into erda-project:master Jun 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Used in pr
Development

Successfully merging this pull request may close these issues.

3 participants