Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure duration of setup (before) & teardown (after) test class #398

Open
mvorisek opened this issue Dec 4, 2023 · 2 comments
Open

Measure duration of setup (before) & teardown (after) test class #398

mvorisek opened this issue Dec 4, 2023 · 2 comments

Comments

@mvorisek
Copy link
Contributor

mvorisek commented Dec 4, 2023

TestCase::setUpBeforeClass and TestCasetearDownAfterClass are not measured now and cannot be measured now, as currently the duration is measured per test.

What about measuring these too and reporting it as Cl::setUpBeforeClass/Cl::tearDownAfterClass items?

basic tests added in: #397

please note this must work with test process isolation correctly, where it might be counted into individual test duration

one example of (possibly) slow TestCase::setUpBeforeClass is https://github.com/atk4/ui/blob/5.0.0/tests/DemosHttpTest.php#L35, ie. things like starting (shared) webserver for a whole test class

related with #378, but not blocking

@localheinz
Copy link
Member

That was my plan, @mvorisek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants