Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Bot is prevent issues from being stale #7

Open
prince-chrismc opened this issue Dec 8, 2020 · 10 comments
Open

Bot is prevent issues from being stale #7

prince-chrismc opened this issue Dec 8, 2020 · 10 comments

Comments

@prince-chrismc
Copy link

Take conan-io/conan-center-index#3367 for instance from October which was not marked stale from the bot's comment 23 days ago.

It would be nice to not comment on older PRs sp they can become stale

@ericLemanissier
Copy link
Owner

Thanks for the report. I think I will prevent the bot from posting messages on PR which had no activity for the last 2 weeks. do you agree ?

@prince-chrismc
Copy link
Author

Yes that would be amazing!

@prince-chrismc
Copy link
Author

Still seems to be an issue, conan-io/conan-center-index#2962 (comment) removed the stale

@ericLemanissier
Copy link
Owner

Right, checking the "updated on" field is not enough, because the stale bot updates prs by posting a message. I'll add another check on "stale" label tomorrow.

@prince-chrismc
Copy link
Author

Thanks!

I can wait for the 40 stale PRs to be gone 😃

ericLemanissier added a commit that referenced this issue Dec 11, 2020
@prince-chrismc
Copy link
Author

The problem thickens!

The stale bot removed the tag in conan-io/conan-center-index#1704

Pulling up the API https://api.github.com/repos/conan-io/conan-center-index/pulls/1704

"updated_at": "2020-12-24T06:18:40Z",

Which is the time the PR was last mentioned....

ericLemanissier added a commit that referenced this issue Dec 28, 2020
@ericLemanissier
Copy link
Owner

Stupid mistake, it should be fixed now, sorry :(

@prince-chrismc
Copy link
Author

No worries, mines going to have the same problem!

@Croydon
Copy link

Croydon commented Mar 7, 2021

If I understand these changes correctly, it would still mean, that if there is a single NEW PR for e.g. Boost every < 14 days, the bot still keeps ALL Boost PRs from getting stale.

The only way to truly prevent that is probably to get the date of the last activity which was not this bot itself. Please correct me if I am missing something

@ericLemanissier
Copy link
Owner

Indeed, I'll work on this in the coming days.
I checked all the PRs detected by this bot, on the only one affected by this is conan-io/conan-center-index#3918

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants