Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrity: TxNums - no gaps, only growing #11211

Open
AskAlexSharov opened this issue Jul 17, 2024 · 0 comments · May be fixed by #12234
Open

integrity: TxNums - no gaps, only growing #11211

AskAlexSharov opened this issue Jul 17, 2024 · 0 comments · May be fixed by #12234
Assignees
@JkLondon
Labels
complexity:low Issue will take up to several days to fix erigon3 imp2 Medium importance
Milestone
3.0.0-alpha6

Comments

@AskAlexSharov
Copy link
Collaborator

AskAlexSharov commented Jul 17, 2024 •
edited
Loading

  • integrity check: TxNum no gaps, only growing (add logic to IntegrityTxnID)
  • add runtime assert inside rawdbv3.TxNums.Append and rawdbv3.TxNums.Truncate. About: no gaps, no decrement, etc...
  • take a look closer to ForcedWrite func - why do we need it? can we remove it?

Which else invariants we can enforce? (assert/integrity checks)?
@AskAlexSharov AskAlexSharov added this to the 3.0.0-beta1 milestone Jul 17, 2024
@yperbasis yperbasis added the imp2 Medium importance label Jul 19, 2024
@AskAlexSharov AskAlexSharov added erigon3 complexity:low Issue will take up to several days to fix labels Jul 26, 2024
@AskAlexSharov AskAlexSharov mentioned this issue Sep 19, 2024
Open
@AskAlexSharov AskAlexSharov changed the title integrity check: TxNum no gaps, only growing integrity: TxNum no gaps, only growing Sep 19, 2024
@AskAlexSharov AskAlexSharov changed the title integrity: TxNum no gaps, only growing integrity: TxNums - no gaps, only growing Sep 19, 2024
@JkLondon JkLondon self-assigned this Sep 19, 2024
@VBulikov VBulikov modified the milestones: 3.0.0-alpha4, 3.0.0-alpha5 Sep 27, 2024
@JkLondon JkLondon linked a pull request Oct 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JkLondon JkLondon

Labels
complexity:low Issue will take up to several days to fix erigon3 imp2 Medium importance
Projects
None yet
Milestone
3.0.0-alpha6
Development

Successfully merging a pull request may close this issue.

[wip] TxNums asserts + ForcedWrite revise erigontech/erigon
4 participants
@VBulikov @yperbasis @AskAlexSharov @JkLondon