Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.19 Upgrade Considerations #26

Closed
sch opened this issue Aug 27, 2018 · 7 comments
Closed

0.19 Upgrade Considerations #26

sch opened this issue Aug 27, 2018 · 7 comments

Comments

@sch
Copy link

sch commented Aug 27, 2018

Hi 👋

Thanks for all of your work maintaining this package. I wanted to know if you intended to upgrade it for Elm 0.19, which removes the Color package entirely.

There's been some talk about breaking the old Color package out as a stand-alone package under elm/color, but nothing is definitive.

I also wanted to ask if, in light of that fact, you might consider duplicating the Color definitions within this package, so that existing applications have a smooth upgrade path.

@eskimoblood
Copy link
Owner

As I'm not so much interested in elm anymore I was not aware of this. How do they handle colors now? If its easy I could at the old package code, but I would also like if someones with more interest in this topic could to this.

@sch
Copy link
Author

sch commented Aug 28, 2018

There's an unpublished Color package on elm/color nowadays. It may be published as-is, or it may undergo some API changes first.

I made a proof-of-concept upgrade in #27 with a bit more info detailing the changes. Let me know your thoughts — based on what's going on in elm/color#1, it may be worth holding off.

@eskimoblood
Copy link
Owner

Yeah, let's wait and see how they decide.

@absynce
Copy link

absynce commented Sep 10, 2018

It looks like elm/color is moving to avh4/elm-color.

@avh4
Copy link

avh4 commented Sep 12, 2018

Just published https://package.elm-lang.org/packages/avh4/elm-color/latest/

Also, I'd be interested in thoughts about what, if anything, would make sense to move from elm-color-extra to elm-color. (Feel free to make a github issue there for any such ideas.)

@noahzgordon
Copy link

@eskimoblood thank you for all your hard work on this library! since I wanted to use its functionality very badly, I forked it, upgraded it and released it under my namespace. the upgraded library can be found here: https://package.elm-lang.org/packages/noahzgordon/elm-color-extra/latest/

since you are not interested in Elm these days, would you be all right with me continuing as the library's maintainer?

@avh4 I would also be happy to move any of this functionality into your Color library! as long as it's all third-party anyway, I think it makes the most sense under one umbrella. let me know what you think.

@eskimoblood
Copy link
Owner

since you are not interested in Elm these days, would you be all right with me continuing as the library's maintainer?

Sure, go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants