Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test in RepoPoller.Integration.GithubTest #29

Open
gausby opened this issue Jan 14, 2019 · 0 comments
Open

Fix flaky test in RepoPoller.Integration.GithubTest #29

gausby opened this issue Jan 14, 2019 · 0 comments

Comments

@gausby
Copy link
Contributor

gausby commented Jan 14, 2019

Currently the test will query the GitHub API; as GitHub has a request rate limiter we see two possible outcomes from this test; either it is an error (rate limited) or "ok" with a bunch of tags.

I think we should consider skipping this test. All it really does is to test TentaCat. Perhaps we could tag it so tests that are hitting the outside world are filtered out when running the test suite while developing.

The rate-limiting is happening quite often when two or more people are working on the project from the same IP address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant