Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Request: Change styles workflow #314

Open
guerrero opened this issue Nov 25, 2016 · 2 comments
Open

Request: Change styles workflow #314

guerrero opened this issue Nov 25, 2016 · 2 comments
Labels
infrastructure Relates to the tools used to develop the website

Comments

@guerrero
Copy link
Contributor

I've tried to make a PR to this repo but I've found that to change it I should do the following steps:

  • Make the change in the specific LESS file
  • Save file and compile LESS
  • Add to GitHub both changes, those frome the LESS file and the others from the compiled file.

The problem here is each time we make a small change we need to commit also the changes made in the compiled styles. A better workaround would be leave Jekyll to manage the compilation and forget about compiled files, following this process we can avoid to track compiled files and there's no penalty due that Jekyll compile these files for us before start serving the resources.

This problem can be solved adding a LESS plugin for Jekyll. It can be solved also using jekyll-less but I've found that it's outdated. Another solution would be to convert all LESS files to Sass and use the default sass plugin that comes with Jekyll. These are the benefits of using Sass instead of LESS:

  • Jekyll provides built-in support for Sass. This means less configuration and therefore less code
  • Bootstrap team is currently using Sass instead of LESS for the 4th version of Bootstrap
  • There is an official Sass alternative for Bootstrap 3
  • As far as I know
  • Sass is more popular than LESS, I am not that kind of guy who prefers a language by popularity but when two languages share a lot of similarities - as it happens in this case - choosing a more popular language means reduce friction for contributors and longevity for its tools.

If you're interested, I can create a PR for change this behaviour with whatever lenguage you choose :)

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Nov 25, 2016
@ilyavolodin
Copy link
Member

You can see some of the discussion about bringing LESS in here: #269 It was mostly just a quick way of restoring our Bootstrap distribution. Before that, we only had pre-compiled CSS classes available. I don't have a preference between LESS and SCSS, I can live with either one.

@kaicataldo
Copy link
Member

Related discussion: #576

@kaicataldo kaicataldo added infrastructure Relates to the tools used to develop the website and removed triage An ESLint team member will look at this issue soon labels Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
infrastructure Relates to the tools used to develop the website
Projects
None yet
Development

No branches or pull requests

4 participants